RESOLVED FIXED 52925
WebKit2: Need API to stop loading a WKFrame 
https://bugs.webkit.org/show_bug.cgi?id=52925
Summary WebKit2: Need API to stop loading a WKFrame
Brian Weinstein
Reported 2011-01-21 14:29:33 PST
We need WebKit2 API to stop loading a WKFrame.
Attachments
[PATCH] Fix (5.41 KB, patch)
2011-01-21 14:33 PST, Brian Weinstein 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brian Weinstein
Comment 1 2011-01-21 14:33:32 PST
Created attachment 79794 [details] [PATCH] Fix
Adam Roben (:aroben)
Comment 2 2011-01-21 15:03:14 PST
Comment on attachment 79794 [details] [PATCH] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=79794&action=review > Source/WebKit2/UIProcess/WebFrameProxy.cpp:90 > + m_page->process()->send(Messages::WebPage::StopLoadingFrame(m_frameID), m_page->pageID()); It looks like this is the first message that WebFrameProxy will be sending. You should check with Sam or Anders that this is the right place to send the message from.
Brian Weinstein
Comment 3 2011-01-21 15:04:03 PST
(In reply to comment #2) > (From update of attachment 79794 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=79794&action=review > > > Source/WebKit2/UIProcess/WebFrameProxy.cpp:90 > > + m_page->process()->send(Messages::WebPage::StopLoadingFrame(m_frameID), m_page->pageID()); > > It looks like this is the first message that WebFrameProxy will be sending. You should check with Sam or Anders that this is the right place to send the message from. Anders told me this was the right way to do it - I will double check to confirm that this is correct. Thanks for the review!
Brian Weinstein
Comment 4 2011-04-07 11:12:45 PDT
Landed in r76403.
Note You need to log in before you can comment on or make changes to this bug.