RESOLVED FIXED 52915
reduce number of FrameLoaderClient::didChangeScrollOffset calls 
https://bugs.webkit.org/show_bug.cgi?id=52915
Summary reduce number of FrameLoaderClient::didChangeScrollOffset calls
Tony Chang
Reported 2011-01-21 13:41:19 PST
reduce number of FrameLoaderClient::didChangeScrollOffset calls
Attachments
Patch (1.60 KB, patch)
2011-01-21 14:00 PST, Tony Chang 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2011-01-21 14:00:18 PST
Created attachment 79786 [details] Patch
Tony Chang
Comment 2 2011-01-21 14:02:42 PST
In particular, it seems like the code that was around lines 550-560 here: http://trac.webkit.org/changeset/76291/trunk/Source/WebCore/platform/ScrollView.cpp got lost in r76291. This results in lots of extra calls to FrameLoaderClient::didChangeScrollOffset. It turns out that chromium is the only port that implements this method (so that session restore can remember the page offset), so it's hard to test using DRT.
Sam Weinig
Comment 3 2011-01-21 14:21:20 PST
Comment on attachment 79786 [details] Patch Thanks for catching this. r+
Tony Chang
Comment 4 2011-01-21 14:32:27 PST
Committed r76395: <http://trac.webkit.org/changeset/76395>
Note You need to log in before you can comment on or make changes to this bug.