Bug 52895 - Web Inspector: move search functions from SourceView to SourceFrame
Summary: Web Inspector: move search functions from SourceView to SourceFrame
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-21 07:39 PST by Pavel Podivilov
Modified: 2011-01-24 00:44 PST (History)
10 users (show)

See Also:

Attachments
Patch. (10.93 KB, patch)
2011-01-21 07:41 PST, Pavel Podivilov 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-01-21 07:39:28 PST 
Web Inspector: move search functions from SourceView to SourceFrame.

This is the last step before eliminating SourceView and ScriptView.
Comment 1 Pavel Podivilov 2011-01-21 07:41:56 PST 
Created attachment 79737 [details]
Patch.
Comment 2 Pavel Feldman 2011-01-21 08:00:11 PST 
Comment on attachment 79737 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=79737&action=review

> Source/WebCore/inspector/front-end/SourceFrame.js:-180
> -        if (this._pendingMarkRange) {

Where did this go?
Comment 3 Pavel Podivilov 2011-01-24 00:38:13 PST 
(In reply to comment #2)
> (From update of attachment 79737 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=79737&action=review
> 
> > Source/WebCore/inspector/front-end/SourceFrame.js:-180
> > -        if (this._pendingMarkRange) {
> 
> Where did this go?

This is not needed anymore since search is implemented in SourceFrame.
Comment 4 Pavel Podivilov 2011-01-24 00:44:49 PST 
Committed r76488: <http://trac.webkit.org/changeset/76488>