WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
52895
Web Inspector: move search functions from SourceView to SourceFrame
https://bugs.webkit.org/show_bug.cgi?id=52895
Summary
Web Inspector: move search functions from SourceView to SourceFrame
Pavel Podivilov
Reported
2011-01-21 07:39:28 PST
Web Inspector: move search functions from SourceView to SourceFrame. This is the last step before eliminating SourceView and ScriptView.
Attachments
Patch.
(10.93 KB, patch)
2011-01-21 07:41 PST
,
Pavel Podivilov
pfeldman
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Pavel Podivilov
Comment 1
2011-01-21 07:41:56 PST
Created
attachment 79737
[details]
Patch.
Pavel Feldman
Comment 2
2011-01-21 08:00:11 PST
Comment on
attachment 79737
[details]
Patch. View in context:
https://bugs.webkit.org/attachment.cgi?id=79737&action=review
> Source/WebCore/inspector/front-end/SourceFrame.js:-180 > - if (this._pendingMarkRange) {
Where did this go?
Pavel Podivilov
Comment 3
2011-01-24 00:38:13 PST
(In reply to
comment #2
)
> (From update of
attachment 79737
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=79737&action=review
> > > Source/WebCore/inspector/front-end/SourceFrame.js:-180 > > - if (this._pendingMarkRange) { > > Where did this go?
This is not needed anymore since search is implemented in SourceFrame.
Pavel Podivilov
Comment 4
2011-01-24 00:44:49 PST
Committed
r76488
: <
http://trac.webkit.org/changeset/76488
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug