Bug 52883 - [Qt] editing/selection/rtl-move-selection-right-left.html fails
Summary: [Qt] editing/selection/rtl-move-selection-right-left.html fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 49511 87008
  Show dependency treegraph
 
Reported: 2011-01-21 04:11 PST by Csaba Osztrogonác
Modified: 2012-10-04 09:00 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2011-01-21 04:11:38 PST
editing/selection/rtl-move-selection-right-left.html introduced in http://trac.webkit.org/changeset/76312 and fails:

--- /home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/layout-test-results/editing/selection/rtl-move-selection-right-left-expected.txt	2011-01-21 03:43:00.092591397 -0800
+++ /home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/layout-test-results/editing/selection/rtl-move-selection-right-left-actual.txt	2011-01-21 03:43:00.092591397 -0800
@@ -5,11 +5,11 @@
 
 PASS Move selection right
 PASS Move selection left
-PASS Extend dragged selection right (Mac)
+FAIL Extend dragged selection right (Mac): Selection start is 9 but should be 10
 PASS Extend dragged selection left (Mac)
-PASS Extend dragged selection right (Win)
+FAIL Extend dragged selection right (Win): Selection start is 9 but should be 10
 PASS Extend dragged selection left (Win)
-PASS Extend dragged selection right (Unix)
+FAIL Extend dragged selection right (Unix): Selection start is 9 but should be 10
 PASS Extend dragged selection left (Unix)
 PASS successfullyParsed is true
 
The runtime of this test is 25 seconds, it seems as if a timeout expired.
Comment 1 Csaba Osztrogonác 2011-01-21 04:17:06 PST
Added to the skipped list: http://trac.webkit.org/changeset/76343
Comment 2 Yael 2011-01-25 15:30:06 PST
Looks like QFontMetrics::width() is not returning the right size for Hebrew characters. It returns 4 as the size of each glyph, which is obviously wrong.
Comment 3 Yael 2011-01-25 17:22:28 PST
(In reply to comment #2)
> Looks like QFontMetrics::width() is not returning the right size for Hebrew characters. It returns 4 as the size of each glyph, which is obviously wrong.

And this is happening only with DumpRenderTree. In QtTestBrowser, the width is correct.
Both of them use font family "Times" for the Hebrew text.
Comment 4 Yael 2011-01-26 08:31:41 PST
I removed the function DumpRenderTree::initializeFonts() from DumpRenderTreeQt.cpp, and this test passes. it is now clear to me that this is a font issue.
Comment 5 Ádám Kallai 2012-10-03 02:08:04 PDT
Now this test is working on Qt. I'm going to removed from the Qt Test Expectations.
Comment 6 Ádám Kallai 2012-10-04 09:00:15 PDT
I skipped it: http://trac.webkit.org/changeset/130385

Closing bug.