WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
52874
Web Inspector: move sticky breakpoints management from InspectorController to InspectorBrowserDebuggerAgent
https://bugs.webkit.org/show_bug.cgi?id=52874
Summary
Web Inspector: move sticky breakpoints management from InspectorController to...
Pavel Podivilov
Reported
2011-01-21 02:02:00 PST
Both InspectorBrowserDebuggerAgent and InspectorDebuggerAgent should manage sticky breakpoints by themselves using InspectorState object. In this patch, sticky breakpoints management moved from InspectorController to InspectorBrowserDebuggerAgent. Patch for InspectorDebuggerAgent will follow.
Attachments
Patch.
(20.94 KB, patch)
2011-01-21 02:02 PST
,
Pavel Podivilov
pfeldman
: review-
Details
Formatted Diff
Diff
Patch.
(20.41 KB, patch)
2011-01-21 02:52 PST
,
Pavel Podivilov
no flags
Details
Formatted Diff
Diff
Fix style.
(20.40 KB, patch)
2011-01-21 02:54 PST
,
Pavel Podivilov
pfeldman
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Pavel Podivilov
Comment 1
2011-01-21 02:02:40 PST
Created
attachment 79711
[details]
Patch.
WebKit Review Bot
Comment 2
2011-01-21 02:05:40 PST
Attachment 79711
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/inspector/InspectorBrowserDebuggerAgent.h:62: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/inspector/InspectorBrowserDebuggerAgent.h:65: The parameter name "breakpoints" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Pavel Feldman
Comment 3
2011-01-21 02:14:52 PST
Comment on
attachment 79711
[details]
Patch. I don't see why this is needed.
Pavel Podivilov
Comment 4
2011-01-21 02:52:08 PST
Created
attachment 79717
[details]
Patch. ChangeLog updated with explanation and link to
bug 52879
.
WebKit Review Bot
Comment 5
2011-01-21 02:53:30 PST
Attachment 79717
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/inspector/InspectorController.h:248: The parameter name "breakpoints" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/inspector/InspectorBrowserDebuggerAgent.h:62: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Pavel Podivilov
Comment 6
2011-01-21 02:54:51 PST
Created
attachment 79718
[details]
Fix style.
Pavel Podivilov
Comment 7
2011-01-21 08:09:13 PST
Committed
r76348
: <
http://trac.webkit.org/changeset/76348
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug