Bug 52874 - Web Inspector: move sticky breakpoints management from InspectorController to InspectorBrowserDebuggerAgent
Summary: Web Inspector: move sticky breakpoints management from InspectorController to...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-21 02:02 PST by Pavel Podivilov
Modified: 2011-01-21 08:09 PST (History)
11 users (show)

See Also:

Attachments
Patch. (20.94 KB, patch)
2011-01-21 02:02 PST, Pavel Podivilov 		pfeldman: review-
Details | Formatted Diff | Diff
Patch. (20.41 KB, patch)
2011-01-21 02:52 PST, Pavel Podivilov 		no flags Details | Formatted Diff | Diff
Fix style. (20.40 KB, patch)
2011-01-21 02:54 PST, Pavel Podivilov 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-01-21 02:02:00 PST 
Both InspectorBrowserDebuggerAgent and InspectorDebuggerAgent should manage sticky breakpoints by themselves using InspectorState object.
In this patch, sticky breakpoints management moved from InspectorController to InspectorBrowserDebuggerAgent. Patch for InspectorDebuggerAgent will follow.
Comment 1 Pavel Podivilov 2011-01-21 02:02:40 PST 
Created attachment 79711 [details]
Patch.
Comment 2 WebKit Review Bot 2011-01-21 02:05:40 PST 
Attachment 79711 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/inspector/InspectorBrowserDebuggerAgent.h:62:  The parameter name "url" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorBrowserDebuggerAgent.h:65:  The parameter name "breakpoints" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Pavel Feldman 2011-01-21 02:14:52 PST 
Comment on attachment 79711 [details]
Patch.

I don't see why this is needed.
Comment 4 Pavel Podivilov 2011-01-21 02:52:08 PST 
Created attachment 79717 [details]
Patch.

ChangeLog updated with explanation and link to bug 52879.
Comment 5 WebKit Review Bot 2011-01-21 02:53:30 PST 
Attachment 79717 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/inspector/InspectorController.h:248:  The parameter name "breakpoints" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorBrowserDebuggerAgent.h:62:  The parameter name "url" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Pavel Podivilov 2011-01-21 02:54:51 PST 
Created attachment 79718 [details]
Fix style.
Comment 7 Pavel Podivilov 2011-01-21 08:09:13 PST 
Committed r76348: <http://trac.webkit.org/changeset/76348>