Bug 52854 - nrwt: fix generated output links in results.html
Summary: nrwt: fix generated output links in results.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-20 16:56 PST by Dirk Pranke
Modified: 2011-01-20 17:06 PST (History)
0 users

See Also:

Attachments
Patch (2.71 KB, patch)
2011-01-20 16:58 PST, Dirk Pranke 		tony: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2011-01-20 16:56:56 PST 
nrwt: fix generated output links in results.html
Comment 1 Dirk Pranke 2011-01-20 16:58:49 PST 
Created attachment 79667 [details]
Patch
Comment 2 Tony Chang 2011-01-20 17:00:49 PST 
Comment on attachment 79667 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=79667&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:98
> +        self.assertEquals(actual_filename,
> +                          "fast/html/article-element-actual.txt")

Nit: doesn't seem worth wrapping here since you didn't wrap in the line preceding it.
Comment 3 Dirk Pranke 2011-01-20 17:01:58 PST 
(In reply to comment #2)
> (From update of attachment 79667 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=79667&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:98
> > +        self.assertEquals(actual_filename,
> > +                          "fast/html/article-element-actual.txt")
> 
> Nit: doesn't seem worth wrapping here since you didn't wrap in the line preceding it.

fair enough. Old habits die hard.
Comment 4 Dirk Pranke 2011-01-20 17:06:57 PST 
Committed r76311: <http://trac.webkit.org/changeset/76311>