WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
52854
nrwt: fix generated output links in results.html
https://bugs.webkit.org/show_bug.cgi?id=52854
Summary
nrwt: fix generated output links in results.html
Dirk Pranke
Reported
2011-01-20 16:56:56 PST
nrwt: fix generated output links in results.html
Attachments
Patch
(2.71 KB, patch)
2011-01-20 16:58 PST
,
Dirk Pranke
tony
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dirk Pranke
Comment 1
2011-01-20 16:58:49 PST
Created
attachment 79667
[details]
Patch
Tony Chang
Comment 2
2011-01-20 17:00:49 PST
Comment on
attachment 79667
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=79667&action=review
> Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:98 > + self.assertEquals(actual_filename, > + "fast/html/article-element-actual.txt")
Nit: doesn't seem worth wrapping here since you didn't wrap in the line preceding it.
Dirk Pranke
Comment 3
2011-01-20 17:01:58 PST
(In reply to
comment #2
)
> (From update of
attachment 79667
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=79667&action=review
> > > Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:98 > > + self.assertEquals(actual_filename, > > + "fast/html/article-element-actual.txt") > > Nit: doesn't seem worth wrapping here since you didn't wrap in the line preceding it.
fair enough. Old habits die hard.
Dirk Pranke
Comment 4
2011-01-20 17:06:57 PST
Committed
r76311
: <
http://trac.webkit.org/changeset/76311
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug