Syncing compositing state and rendering are intertwined in WKCACFLayerRenderer, but shouldn't be
Created attachment 79664 [details] Separate compositing state syncing from rendering in WKCACFLayerRenderer
Comment on attachment 79664 [details] Separate compositing state syncing from rendering in WKCACFLayerRenderer View in context: https://bugs.webkit.org/attachment.cgi?id=79664&action=review > Source/WebCore/platform/graphics/ca/win/CompositingStateSyncer.cpp:92 > + m_isCallingRenderers = true; > + for (size_t i = 0; i < renderers.size(); ++i) > + renderers[i]->syncCompositingStateNowIfNeeded(); > + m_isCallingRenderers = false; The name m_isCallingRenderers is a bit vague (and easily confused with Render objects). > Source/WebCore/platform/graphics/ca/win/CompositingStateSyncer.h:39 > +class CompositingStateSyncer { I'm not a big fan of this name. I started to use "flush pending layer changes" nomenclature in RenderLayerCompositor (we're not really synchronizing anything here).
Comment on attachment 79664 [details] Separate compositing state syncing from rendering in WKCACFLayerRenderer View in context: https://bugs.webkit.org/attachment.cgi?id=79664&action=review >> Source/WebCore/platform/graphics/ca/win/CompositingStateSyncer.h:39 >> +class CompositingStateSyncer { > > I'm not a big fan of this name. I started to use "flush pending layer changes" nomenclature in RenderLayerCompositor (we're not really synchronizing anything here). The current name certainly seems more consistent with the current terminology (e.g., ChromeClient::scheduleCompositingStateSync). But I guess it's better to be forward-looking, if you're planning to change the existing names. Maybe LayerChangeFlusher is the way to go (along with flushLayerChangesSoon(WKCACFLayerRenderer*) and m_isFlushingLayerChanges).
Comment on attachment 79664 [details] Separate compositing state syncing from rendering in WKCACFLayerRenderer This patch breaks <video>.
I went ahead and got rid of uses of "sync compositing state" in Windows-specific code in bug 52894 and bug 52898. I'll upload a new patch that takes the new names into account and also fixes <video>.
Created attachment 79744 [details] Separate flushing layer changes from rendering in CACFLayerView
Yet another rename in bug 52898 means that this patch will have to be updated before landing, but it will just be a mechanical rename change.
Committed r76372: <http://trac.webkit.org/changeset/76372>