Bug 52851 - check-webkit-style should catch use of #import in non-Mac-only files
Summary: check-webkit-style should catch use of #import in non-Mac-only files
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-20 16:09 PST by Jon Honeycutt
Modified: 2011-03-10 20:40 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Honeycutt 2011-01-20 16:09:26 PST 
It would be nice if the style checker could catch use of #import on files that will be built on platforms other than the Mac to prevent build errors like <http://trac.webkit.org/changeset/75981>.
Comment 1 David Levin 2011-01-20 22:16:13 PST 
I don't know what this check would be.

Is the check 
    if file extension == 'cpp' and file has '#import', then print 'Don't do #import. This is a C++ file.'
?