Bug 52837 – [v8] CodeGeneratorV8 generates incorrect code for callbacks with no parameters

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[James Robinson]

[v8] CodeGeneratorV8 generates incorrect code for callbacks with no parameters

[James Robinson]

Created attachment 79643 [details]
Patch

[Nate Chapin]

Comment on attachment 79643 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=79643&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:2406
> +            } else {
> +                push(@implContent, "\n    v8::Handle<v8::Value> *argv = 0;\n\n");
> +            }

Nit: no {} for the else statement

[James Robinson]

(In reply to comment #2)
> (From update of attachment 79643 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=79643&action=review
> 
> > Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:2406
> > +            } else {
> > +                push(@implContent, "\n    v8::Handle<v8::Value> *argv = 0;\n\n");
> > +            }
> 
> Nit: no {} for the else statement

The other one-line conditionals in this file seem to use {}s

[Nate Chapin]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 79643 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=79643&action=review
> > 
> > > Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:2406
> > > +            } else {
> > > +                push(@implContent, "\n    v8::Handle<v8::Value> *argv = 0;\n\n");
> > > +            }
> > 
> > Nit: no {} for the else statement
> 
> The other one-line conditionals in this file seem to use {}s

Hmm....I had forgotten that.  nvm then.

[James Robinson]

Committed r76277: <http://trac.webkit.org/changeset/76277>

[Adam Barth]

Comment on attachment 79643 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=79643&action=review

>>>> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:2406
>>>> +            } else {
>>>> +                push(@implContent, "\n    v8::Handle<v8::Value> *argv = 0;\n\n");
>>>> +            }
>>> 
>>> Nit: no {} for the else statement
>> 
>> The other one-line conditionals in this file seem to use {}s
> 
> Hmm....I had forgotten that.  nvm then.

I think they're required in Perl.