Bug 52834 - handle cases where PrettyPatch.rb doesn't linkify filenames
Summary: handle cases where PrettyPatch.rb doesn't linkify filenames
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-20 12:46 PST by Ojan Vafai
Modified: 2011-01-20 16:05 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.57 KB, patch)
2011-01-20 12:47 PST, Ojan Vafai 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2011-01-20 12:46:43 PST 
handle cases where PrettyPatch.rb doesn't linkify filenames
Comment 1 Ojan Vafai 2011-01-20 12:47:06 PST 
Created attachment 79638 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-01-20 13:39:13 PST 
Comment on attachment 79638 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=79638&action=review

I think this is really an aroben patch to review.

> Websites/bugs.webkit.org/code-review.js:343
> +        file_link.target = "_blank";
> +        file_link.href += url_hash;
> +        diff_links.append(tracLinks(file_name, url_hash));

two space indent?
Comment 3 Ojan Vafai 2011-01-20 13:43:12 PST 
Comment on attachment 79638 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=79638&action=review

>> Websites/bugs.webkit.org/code-review.js:343
>> +        diff_links.append(tracLinks(file_name, url_hash));
> 
> two space indent?

Following the style of the file. Eventually we should make this file follow something closer to standard WebKit style.
Comment 4 Adam Barth 2011-01-20 13:51:52 PST 
jQuery in four-space indent is painful, which is why the file uses two-space indent.
Comment 5 Ojan Vafai 2011-01-20 16:05:03 PST 
Committed r76302: <http://trac.webkit.org/changeset/76302>