Bug 52814 - REGRESSION(r76177): All JavaScriptCore tests fail on ARM
Summary: REGRESSION(r76177): All JavaScriptCore tests fail on ARM
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Blocker
Assignee: Nobody
Depends on:
Blocks: 52622
  Show dependency treegraph
Reported: 2011-01-20 07:26 PST by Csaba Osztrogonác
Modified: 2011-01-22 03:25 PST (History)
7 users (show)

See Also:

proposed fix (1.40 KB, patch)
2011-01-21 11:37 PST, Peter Gal
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2011-01-20 07:26:22 PST
http://trac.webkit.org/changeset/76177 made all jsc tests fail on ARM

Gabor or Zoltan, could you check it, please?
Comment 1 Peter Gal 2011-01-21 11:37:50 PST
Created attachment 79767 [details]
proposed fix

I'm not an OwnPtr expert, but shouldn't we need to get the approximateByteSize before releasing the OwnPtr?

Tested on an ARM build, with run-sunspider and run-javascriptcore-tests all runs ok.
Comment 2 Darin Adler 2011-01-21 11:45:47 PST
Comment on attachment 79767 [details]
proposed fix

Perfect. Great fix. This depends on the compiler’s order of evaluation for arguments, so could behave differently for different compilers.
Comment 3 WebKit Commit Bot 2011-01-21 12:01:19 PST
Comment on attachment 79767 [details]
proposed fix

Clearing flags on attachment: 79767

Committed r76376: <http://trac.webkit.org/changeset/76376>
Comment 4 WebKit Commit Bot 2011-01-21 12:01:24 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Antti Koivisto 2011-01-22 03:25:22 PST
Good catch. Thanks for fixing this.