Bug 52808 - Web Inspector: [Chromium] REGRESSION: Using the "Back" button while profiling causes renderer crash
Summary: Web Inspector: [Chromium] REGRESSION: Using the "Back" button while profiling...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mikhail Naganov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-20 05:52 PST by Mikhail Naganov
Modified: 2011-01-21 07:30 PST (History)
13 users (show)

See Also:


Attachments
patch (2.12 KB, patch)
2011-01-20 06:03 PST, Mikhail Naganov
yurys: review+
mnaganov: commit-queue?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Naganov 2011-01-20 05:52:12 PST
From http://code.google.com/p/chromium/issues/detail?id=70228:

Chromium 10.0.642.0 (71590)

What steps will reproduce the problem?
1. Navigate to some page (e.g. google.com)
2. In the same tab, navigate to other page (e.g. yandex.ru)
3. Open DevTools, open CPU profiles page, start profiling.
4. Press the "Back" button in browser.

Expected: tab navigates back to the page from item 1., profiling continues.
Actual: tab renderer crashes.
Comment 1 Mikhail Naganov 2011-01-20 06:03:34 PST
Created attachment 79589 [details]
patch
Comment 2 Yury Semikhatsky 2011-01-21 06:22:14 PST
Probably related Chromium issue: http://code.google.com/p/chromium/issues/detail?id=67052
Comment 3 Yury Semikhatsky 2011-01-21 06:25:46 PST
Comment on attachment 79589 [details]
patch

r+ for this quick fix but we need to figure out what causes the crash.
Comment 4 Mikhail Naganov 2011-01-21 07:03:31 PST
Committed manually http://trac.webkit.org/changeset/76345

2011-01-21  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [Chromium] REGRESSION: Using the "Back" button
        while profiling causes renderer crash.

        https://bugs.webkit.org/show_bug.cgi?id=52808

        * inspector/InspectorProfilerAgent.cpp:
        (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
        (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):


I agree, we should investigate the real cause of the crash.
Comment 5 WebKit Review Bot 2011-01-21 07:30:59 PST
http://trac.webkit.org/changeset/76345 might have broken GTK Linux 64-bit Debug
The following tests are not passing:
loader/reload-subresource-when-type-changes.html