Bug 52808 – Web Inspector: [Chromium] REGRESSION: Using the "Back" button while profiling causes renderer crash

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Mikhail Naganov]

From http://code.google.com/p/chromium/issues/detail?id=70228:

Chromium 10.0.642.0 (71590)

What steps will reproduce the problem?
1. Navigate to some page (e.g. google.com)
2. In the same tab, navigate to other page (e.g. yandex.ru)
3. Open DevTools, open CPU profiles page, start profiling.
4. Press the "Back" button in browser.

Expected: tab navigates back to the page from item 1., profiling continues.
Actual: tab renderer crashes.

[Mikhail Naganov]

Created attachment 79589 [details]
patch

[Yury Semikhatsky]

Probably related Chromium issue: http://code.google.com/p/chromium/issues/detail?id=67052

[Yury Semikhatsky]

Comment on attachment 79589 [details]
patch

r+ for this quick fix but we need to figure out what causes the crash.

[Mikhail Naganov]

Committed manually http://trac.webkit.org/changeset/76345

2011-01-21  Mikhail Naganov  <[e-mail]>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [Chromium] REGRESSION: Using the "Back" button
        while profiling causes renderer crash.

        https://bugs.webkit.org/show_bug.cgi?id=52808

        * inspector/InspectorProfilerAgent.cpp:
        (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
        (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):


I agree, we should investigate the real cause of the crash.

[WebKit Review Bot]

http://trac.webkit.org/changeset/76345 might have broken GTK Linux 64-bit Debug
The following tests are not passing:
loader/reload-subresource-when-type-changes.html