SVG Pattern does not take the preserveAspectRatio of a references Pattern (references by xlink:href). Need to add a test later. Just opening the bug for now.
Created attachment 79613 [details]
Testcase: Should see a perfect smiley
You should see a perfect smiley, if the pattern uses the preserveAspectRatio of the referenced pattern.
Created attachment 79637 [details]
Comment on attachment 79637 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=79637&action=review
Code and test look great, just tiny nitpicks, so r+ from me.
Tiny nitpick, the wording could be better, could you rephrase a bit, "Modified PatternAttributes" is terse, and I don't think you should
put a comma after it for instance.
Better: Added a test case to check that we take preserveAspectRatio of a referenced SVGPattern into account.
> + x="-20" y="0" width="100" height="80" viewBox="0 0 20 40">
One space character too much in there :)
Indentation is not completely consistent.
Committed r76274: <http://trac.webkit.org/changeset/76274>