Bug 52800 - REGRESSION: Inset shadow with too large border radius misses rounded corner.
Summary: REGRESSION: Inset shadow with too large border radius misses rounded corner.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P1 Normal
Assignee: Nobody
URL: http://habrahabr.ru/blogs/css/103170/
Keywords: Regression
Depends on:
Blocks:
 
Reported: 2011-01-20 04:44 PST by Hajime Morrita
Modified: 2011-01-30 20:24 PST (History)
2 users (show)

See Also:


Attachments
a repro. (444 bytes, text/html)
2011-01-20 22:19 PST, Hajime Morrita
no flags Details
Patch (24.55 KB, patch)
2011-01-23 21:05 PST, Hajime Morrita
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2011-01-20 04:44:14 PST
If  width -  border radius - border width goes negative, the shadow misses rounded corner.
Only happens on ToT so http://trac.webkit.org/changeset/76083 has this regression.
I'll post the fix in a few days.
Comment 1 Hajime Morrita 2011-01-20 22:19:52 PST
Created attachment 79696 [details]
a repro.
Comment 2 Hajime Morrita 2011-01-23 21:05:49 PST
Created attachment 79888 [details]
Patch
Comment 3 Hajime Morrita 2011-01-23 21:07:42 PST
Simon, Mitz, could you take a look at this? It should be a kind of obvious....
Comment 4 Hajime Morrita 2011-01-26 17:08:17 PST
Ping. Simon?
I'd like to fix this  regression soon because this actually breaks things...

(In reply to comment #3)
> Simon, Mitz, could you take a look at this? It should be a kind of obvious....
Comment 5 Eric Seidel (no email) 2011-01-30 05:13:45 PST
Comment on attachment 79888 [details]
Patch

Looks sane to me.
Comment 6 Hajime Morrita 2011-01-30 20:24:03 PST
Committed r77105: <http://trac.webkit.org/changeset/77105>
Comment 7 Hajime Morrita 2011-01-30 20:24:53 PST
Landedl. Thanks Eric!