This is a feature request. I often have to go look up trac logs to see when and why certain code is added. It'll be really useful if review page had a link to a trac page with annotation with the right line number.
I wonder if we could also include links for the annotation and revision log. It's a pain to load trac just to click on the link you really want to get to. To avoid clutter, we could only display the links when you mouseover the filename H1 element.
Yeah, I bet there's a bunch of cool stuff we could do along these lines.
Created attachment 79524 [details] Patch
Comment on attachment 79524 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79524&action=review Screenshot? :) > Websites/bugs.webkit.org/code-review.js:346 > + function tracLinksHtml(file_name, url_hash) { > + return '<a href="http://trac.webkit.org/browser/trunk/' + file_name + '?annotate=blame' + url_hash + '" target="_blank">annotate</a>' + > + '<a href="http://trac.webkit.org/log/trunk/' + file_name + '" target="_blank">revision log</a>'; > + } You haz the XSS. file_name isn't trusted! Please use the DOM to construct these links.
Created attachment 79619 [details] Patch
Comment on attachment 79524 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79524&action=review >> Websites/bugs.webkit.org/code-review.js:346 >> + } > > You haz the XSS. file_name isn't trusted! Please use the DOM to construct these links. Yikes. Sorry for the n00b.
Created attachment 79620 [details] screenshot
Comment on attachment 79619 [details] Patch Thanks! Very cool.
Thanks for the feature!
Committed r76270: <http://trac.webkit.org/changeset/76270>