Bug 52745 - Chromium builders don't delete unversioned directories when DEPS change
Summary: Chromium builders don't delete unversioned directories when DEPS change
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-19 14:24 PST by Adam Barth
Modified: 2011-01-20 04:16 PST (History)
2 users (show)

See Also:


Attachments
Patch (1.26 KB, patch)
2011-01-19 14:26 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-01-19 14:24:31 PST
Chromium builders don't delete unversioned directories when DEPS change
Comment 1 Adam Barth 2011-01-19 14:26:19 PST
Created attachment 79483 [details]
Patch
Comment 2 Tony Chang 2011-01-19 14:31:48 PST
Comment on attachment 79483 [details]
Patch

I'm not 100% convinced we should just be piggy backing off of --force here.  It could result in losing work if a directory moves out from under you.  Maybe that's rare enough and since the user already passed in a flag that it's not a big deal?
Comment 3 Tony Chang 2011-01-19 14:32:54 PST
Comment on attachment 79483 [details]
Patch

I guess it's ok, but if someone loses data, I'm going to direct them to you :)
Comment 4 Adam Barth 2011-01-19 14:45:17 PST
IMHO, if you're passing the --force flag, you shouldn't be surprised if something bad happens, but maybe that's just because I've been abused by git for too long.  :)
Comment 5 Tony Chang 2011-01-19 14:48:11 PST
(In reply to comment #4)
> IMHO, if you're passing the --force flag, you shouldn't be surprised if something bad happens, but maybe that's just because I've been abused by git for too long.  :)

I agree, but it's weird to have different semantics for --force depending on whether you're in chromium or webkit.
Comment 6 Adam Barth 2011-01-19 21:20:44 PST
Comment on attachment 79483 [details]
Patch

Ok.  I think I can stand behind update-webkit-chromium not being the same as gclient sync as well as --force leading to dataloss.  We'll see how I feel when someone is sad later.  :(
Comment 7 WebKit Commit Bot 2011-01-20 04:16:21 PST
Comment on attachment 79483 [details]
Patch

Clearing flags on attachment: 79483

Committed r76222: <http://trac.webkit.org/changeset/76222>
Comment 8 WebKit Commit Bot 2011-01-20 04:16:28 PST
All reviewed patches have been landed.  Closing bug.