Bug 52741 - Add run-time enable support for the web audio API
Summary: Add run-time enable support for the web audio API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-19 14:12 PST by Chris Rogers
Modified: 2011-01-21 14:50 PST (History)
5 users (show)

See Also:


Attachments
Patch (14.24 KB, patch)
2011-01-19 14:17 PST, Chris Rogers
fishd: review+
fishd: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2011-01-19 14:12:12 PST
Add run-time enable support for the web audio API
Comment 1 Chris Rogers 2011-01-19 14:17:33 PST
Created attachment 79481 [details]
Patch
Comment 2 Darin Fisher (:fishd, Google) 2011-01-19 14:26:06 PST
Comment on attachment 79481 [details]
Patch

R=me for the WebCore and WebKit/chromium/ changes.  I'm not the best reviewer for the WebKit/{mac,win} changes, but they look reasonable to me.  One question about the WebKit/win/ code though... why not update WebPreferences for that port?  Or, put another way, why bother updating WebPreferences for WebKit/mac/ if you are not also going to do so for WebKit/win/?
Comment 3 WebKit Review Bot 2011-01-19 18:08:32 PST
Attachment 79481 [details] did not build on mac:
Build output: http://queues.webkit.org/results/7594232
Comment 4 Chris Rogers 2011-01-21 13:43:53 PST
Darin, the reason the Safari mac port stuff is in this patch is because the web audio API already works there, but the Safari win isn't really ported yet so we don't need the complete implementation for that yet.
Comment 5 Chris Rogers 2011-01-21 13:44:26 PST
Committed r76390: <http://trac.webkit.org/changeset/76390>
Comment 6 WebKit Review Bot 2011-01-21 14:50:17 PST
http://trac.webkit.org/changeset/76390 might have broken GTK Linux 64-bit Debug
The following tests are not passing:
editing/selection/select-box.html
transforms/2d/zoom-menulist.html