Bug 52717 - Web Inspector: move methods from InjectedScript domain into DOM, Runtime and Debugger domains. Introduce InspectorRuntimeAgent.
Summary: Web Inspector: move methods from InjectedScript domain into DOM, Runtime and ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-19 06:20 PST by Pavel Feldman
Modified: 2011-01-19 10:28 PST (History)
16 users (show)

See Also:


Attachments
[PATCH] Proposed change. (57.16 KB, patch)
2011-01-19 06:22 PST, Pavel Feldman
no flags Details | Formatted Diff | Diff
[PATCH] Proposed change with missing files added. (65.91 KB, patch)
2011-01-19 06:46 PST, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff
[PATCH] Review comments addressed, for landing. (65.16 KB, patch)
2011-01-19 07:09 PST, Pavel Feldman
pfeldman: review+
Details | Formatted Diff | Diff
[PATCH] Patch for landing. (65.21 KB, patch)
2011-01-19 07:17 PST, Pavel Feldman
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-01-19 06:20:05 PST
Patch to follow.
Comment 1 Pavel Feldman 2011-01-19 06:22:51 PST
Created attachment 79414 [details]
[PATCH] Proposed change.
Comment 2 WebKit Review Bot 2011-01-19 06:24:49 PST
Attachment 79414 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1

Source/WebCore/inspector/InspectorDOMAgent.h:105:  The parameter name "injectedScriptHost" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorDOMAgent.h:105:  The parameter name "frontend" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorDOMAgent.h:131:  The parameter name "document" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorDOMAgent.h:140:  The parameter name "node" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorDOMAgent.h:148:  The parameter name "document" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorDOMAgent.h:161:  The parameter name "document" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorDOMAgent.h:162:  The parameter name "document" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorDOMAgent.h:164:  The parameter name "event" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorDOMAgent.h:168:  The parameter name "node" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorDOMAgent.h:169:  The parameter name "node" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorDOMAgent.h:173:  The parameter name "node" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorDOMAgent.h:177:  The parameter name "node" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorDOMAgent.h:178:  The parameter name "element" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorDOMAgent.h:180:  The parameter name "registeredEventListener" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorDOMAgent.h:180:  The parameter name "node" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 15 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Review Bot 2011-01-19 06:30:13 PST
Attachment 79414 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/7585194
Comment 4 Early Warning System Bot 2011-01-19 06:36:24 PST
Attachment 79414 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7560212
Comment 5 WebKit Review Bot 2011-01-19 06:36:53 PST
Attachment 79414 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7500204
Comment 6 Build Bot 2011-01-19 06:43:13 PST
Attachment 79414 [details] did not build on win:
Build output: http://queues.webkit.org/results/7530218
Comment 7 Pavel Feldman 2011-01-19 06:46:49 PST
Created attachment 79418 [details]
[PATCH] Proposed change with missing files added.
Comment 8 Yury Semikhatsky 2011-01-19 07:03:01 PST
Comment on attachment 79418 [details]
[PATCH] Proposed change with missing files added.

View in context: https://bugs.webkit.org/attachment.cgi?id=79418&action=review

> Source/WebCore/inspector/InjectedScriptHost.cpp:152
> + 

Remove this space.

> Source/WebCore/inspector/InjectedScriptHost.cpp:158
> +InjectedScript InjectedScriptHost::injectedScriptForMainWorld()

injectedScriptForMainWorld -> injectedScriptForMainFrame

> Source/WebCore/inspector/InspectorRuntimeAgent.cpp:83
> +InjectedScript InspectorRuntimeAgent::injectedScriptForObjectId(InspectorObject* objectId)

Let's move this method into InjectedScriptHost and move pushNodeToFrontend into DOM agent.
Comment 9 Pavel Feldman 2011-01-19 07:09:31 PST
Created attachment 79419 [details]
[PATCH] Review comments addressed, for landing.
Comment 10 Pavel Feldman 2011-01-19 07:17:16 PST
Created attachment 79422 [details]
[PATCH] Patch for landing.
Comment 11 Pavel Feldman 2011-01-19 10:28:49 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
        C       Source/WebCore/inspector/InjectedScript.h => Source/WebCore/inspector/InspectorRuntimeAgent.h
        M       Source/WebCore/CMakeLists.txt
        M       Source/WebCore/ChangeLog
        M       Source/WebCore/GNUmakefile.am
        M       Source/WebCore/WebCore.gypi
        M       Source/WebCore/WebCore.pro
        M       Source/WebCore/WebCore.vcproj/WebCore.vcproj
        M       Source/WebCore/WebCore.xcodeproj/project.pbxproj
        M       Source/WebCore/inspector/CodeGeneratorInspector.pm
        M       Source/WebCore/inspector/InjectedScript.cpp
        M       Source/WebCore/inspector/InjectedScript.h
        M       Source/WebCore/inspector/InjectedScriptHost.cpp
        M       Source/WebCore/inspector/InjectedScriptHost.h
        M       Source/WebCore/inspector/InjectedScriptSource.js
        M       Source/WebCore/inspector/Inspector.idl
        M       Source/WebCore/inspector/InspectorController.cpp
        M       Source/WebCore/inspector/InspectorController.h
        M       Source/WebCore/inspector/InspectorDOMAgent.cpp
        M       Source/WebCore/inspector/InspectorDOMAgent.h
        M       Source/WebCore/inspector/InspectorDebuggerAgent.cpp
        M       Source/WebCore/inspector/InspectorDebuggerAgent.h
        A       Source/WebCore/inspector/InspectorRuntimeAgent.cpp
        M       Source/WebCore/inspector/front-end/ConsoleView.js
        M       Source/WebCore/inspector/front-end/ScriptsPanel.js
Committed r76136