Bug 52717 – Web Inspector: move methods from InjectedScript domain into DOM, Runtime and Debugger domains. Introduce InspectorRuntimeAgent.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Patch to follow.

[Pavel Feldman]

Created attachment 79414 [details]
[PATCH] Proposed change.

[WebKit Review Bot]

Attachment 79414 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1

Source/WebCore/inspector/InspectorDOMAgent.h:105:  The parameter name "injectedScriptHost" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorDOMAgent.h:105:  The parameter name "frontend" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorDOMAgent.h:131:  The parameter name "document" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorDOMAgent.h:140:  The parameter name "node" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorDOMAgent.h:148:  The parameter name "document" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorDOMAgent.h:161:  The parameter name "document" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorDOMAgent.h:162:  The parameter name "document" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorDOMAgent.h:164:  The parameter name "event" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorDOMAgent.h:168:  The parameter name "node" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorDOMAgent.h:169:  The parameter name "node" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorDOMAgent.h:173:  The parameter name "node" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorDOMAgent.h:177:  The parameter name "node" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorDOMAgent.h:178:  The parameter name "element" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorDOMAgent.h:180:  The parameter name "registeredEventListener" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorDOMAgent.h:180:  The parameter name "node" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 15 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Attachment 79414 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/7585194

[Early Warning System Bot]

Attachment 79414 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7560212

[WebKit Review Bot]

Attachment 79414 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7500204

[Build Bot]

Attachment 79414 [details] did not build on win:
Build output: http://queues.webkit.org/results/7530218

[Pavel Feldman]

Created attachment 79418 [details]
[PATCH] Proposed change with missing files added.

[Yury Semikhatsky]

Comment on attachment 79418 [details]
[PATCH] Proposed change with missing files added.

View in context: https://bugs.webkit.org/attachment.cgi?id=79418&action=review

> Source/WebCore/inspector/InjectedScriptHost.cpp:152
> + 

Remove this space.

> Source/WebCore/inspector/InjectedScriptHost.cpp:158
> +InjectedScript InjectedScriptHost::injectedScriptForMainWorld()

injectedScriptForMainWorld -> injectedScriptForMainFrame

> Source/WebCore/inspector/InspectorRuntimeAgent.cpp:83
> +InjectedScript InspectorRuntimeAgent::injectedScriptForObjectId(InspectorObject* objectId)

Let's move this method into InjectedScriptHost and move pushNodeToFrontend into DOM agent.

[Pavel Feldman]

Created attachment 79419 [details]
[PATCH] Review comments addressed, for landing.

[Pavel Feldman]

Created attachment 79422 [details]
[PATCH] Patch for landing.

[Pavel Feldman]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
        C       Source/WebCore/inspector/InjectedScript.h => Source/WebCore/inspector/InspectorRuntimeAgent.h
        M       Source/WebCore/CMakeLists.txt
        M       Source/WebCore/ChangeLog
        M       Source/WebCore/GNUmakefile.am
        M       Source/WebCore/WebCore.gypi
        M       Source/WebCore/WebCore.pro
        M       Source/WebCore/WebCore.vcproj/WebCore.vcproj
        M       Source/WebCore/WebCore.xcodeproj/project.pbxproj
        M       Source/WebCore/inspector/CodeGeneratorInspector.pm
        M       Source/WebCore/inspector/InjectedScript.cpp
        M       Source/WebCore/inspector/InjectedScript.h
        M       Source/WebCore/inspector/InjectedScriptHost.cpp
        M       Source/WebCore/inspector/InjectedScriptHost.h
        M       Source/WebCore/inspector/InjectedScriptSource.js
        M       Source/WebCore/inspector/Inspector.idl
        M       Source/WebCore/inspector/InspectorController.cpp
        M       Source/WebCore/inspector/InspectorController.h
        M       Source/WebCore/inspector/InspectorDOMAgent.cpp
        M       Source/WebCore/inspector/InspectorDOMAgent.h
        M       Source/WebCore/inspector/InspectorDebuggerAgent.cpp
        M       Source/WebCore/inspector/InspectorDebuggerAgent.h
        A       Source/WebCore/inspector/InspectorRuntimeAgent.cpp
        M       Source/WebCore/inspector/front-end/ConsoleView.js
        M       Source/WebCore/inspector/front-end/ScriptsPanel.js
Committed r76136