Bug 52695 - WK2 - Multiple crashes in PlatformCALayer::replaceSublayer
Summary: WK2 - Multiple crashes in PlatformCALayer::replaceSublayer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.6
: P2 Normal
Assignee: Chris Marrin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-01-18 18:49 PST by Chris Marrin
Modified: 2011-01-19 12:03 PST (History)
5 users (show)

See Also:


Attachments
Patch (8.17 KB, patch)
2011-01-18 18:56 PST, Chris Marrin
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Marrin 2011-01-18 18:49:49 PST
In WK2 making the window > 2000 pixels wide (or high) crashes because we are trying to switch the root layer to be tiled. Since it has no superlayer, there is no way to reattach it, so we crash.

In radar 8751147
Comment 1 Chris Marrin 2011-01-18 18:56:28 PST
Created attachment 79382 [details]
Patch
Comment 2 Simon Fraser (smfr) 2011-01-18 20:19:46 PST
Comment on attachment 79382 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=79382&action=review

> Source/WebKit2/ChangeLog:13
> +        Added a hostingLayer as the parent of the existing drawingLayer.
> +        The hostingLayer is now the root which is passed to the 
> +        remote context. It never changes except to track the size
> +        of the window. The drawingLayer is now a child of the 
> +        hostingLayer, which allow it to switch between tiled and
> +        non-tiled.

s/drawingLayer/backingLayer

> Source/WebKit2/ChangeLog:15
> +        I also not give back accurate settings for debug borders and

s/not/now
Comment 3 Anders Carlsson 2011-01-19 11:27:02 PST
Committed r76143: <http://trac.webkit.org/changeset/76143>
Comment 4 WebKit Review Bot 2011-01-19 12:03:40 PST
http://trac.webkit.org/changeset/76143 might have broken SnowLeopard Intel Release (Tests)