Bug 52694 - new-run-webkit-tests: add a --build-directory command line argument
Summary: new-run-webkit-tests: add a --build-directory command line argument
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-18 18:33 PST by Dirk Pranke
Modified: 2011-01-18 21:15 PST (History)
5 users (show)

See Also:

Attachments
Patch (4.50 KB, patch)
2011-01-18 18:35 PST, Dirk Pranke 		tony: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2011-01-18 18:33:00 PST 
new-run-webkit-tests: add a --build-directory command line argument
Comment 1 Dirk Pranke 2011-01-18 18:35:01 PST 
Created attachment 79379 [details]
Patch
Comment 2 Tony Chang 2011-01-18 19:54:07 PST 
Comment on attachment 79379 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=79379&action=review

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:281
> +        optparse.make_option("--build-directory",
> +            help="Absolute path to the directory under which build files are kept (should not include configuration)"),

Does it have to be absolute?  Won't paths relative to where NRWT is run from work?
Comment 3 Dirk Pranke 2011-01-18 21:09:47 PST 
(In reply to comment #2)
> (From update of attachment 79379 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=79379&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:281
> > +        optparse.make_option("--build-directory",
> > +            help="Absolute path to the directory under which build files are kept (should not include configuration)"),
> 
> Does it have to be absolute?  Won't paths relative to where NRWT is run from work?

Yeah, technically relative paths would work, too. I'll fix the comment when I land the patch.
Comment 4 Dirk Pranke 2011-01-18 21:15:20 PST 
Committed r76101: <http://trac.webkit.org/changeset/76101>