Bug 52685 - Refactoring: WebKit should have RoundedFloatRect
Summary: Refactoring: WebKit should have RoundedFloatRect
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-18 16:56 PST by Hajime Morrita
Modified: 2012-06-25 13:58 PDT (History)
4 users (show)

See Also:


Attachments
Patch (22.30 KB, patch)
2011-01-19 01:16 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2011-01-18 16:56:34 PST
Coined at Bug Bug 51664.
As an argument for Path::addRoundedRect(), we could make RoundedFloatRect,
which supports implicit conversion from RoundedIntRect.
Comment 1 Hajime Morrita 2011-01-19 01:16:18 PST
Created attachment 79400 [details]
Patch
Comment 2 Hajime Morrita 2011-01-19 01:17:37 PST
Hi Antonio, Could you take a look when you have time?
We have a new member for rounded rect family.
Comment 3 Antonio Gomes 2011-01-19 06:33:49 PST
Comment on attachment 79400 [details]
Patch

LGTM.

ps: I though the patch had landed already.
Comment 4 Hajime Morrita 2011-01-19 17:38:00 PST
HI Antonio, thank you for taking a look!

> 
> ps: I though the patch had landed already.
I'm sorry but I miss the point... Are you saying about Bug 51664?
Comment 5 Simon Fraser (smfr) 2011-01-20 08:35:10 PST
Is it really worth it, for the 4 lines of code that use it?
Comment 6 Hajime Morrita 2011-01-20 17:50:44 PST
> Is it really worth it, for the 4 lines of code that use it?
Hmm, good question. I just thought it is symmetrically reasonable.
Comment 7 Eric Seidel (no email) 2011-01-21 02:57:17 PST
Comment on attachment 79400 [details]
Patch

We could use a template to share code with the Int version.  But i agree, this is probably pre-mature optimization to add a class for just 4 lines. :)
Comment 8 Hajime Morrita 2011-01-23 15:37:12 PST
Comment on attachment 79400 [details]
Patch

Thank you for the feedback.
I'm removing r? at this time and will back when the time is ripe :-)