Bug 52677 - Update fast/events/offsetX-offsetY.html now that bug is fixed
Summary: Update fast/events/offsetX-offsetY.html now that bug is fixed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-18 15:54 PST by Joseph Pecoraro
Modified: 2011-01-19 06:39 PST (History)
1 user (show)

See Also:


Attachments
[PATCH] Update Test (2.00 KB, patch)
2011-01-18 15:57 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2011-01-18 15:54:15 PST
LayoutTests/fast/events/offsetX-offsetY.html had commented out code:
http://trac.webkit.org/browser/trunk/LayoutTests/fast/events/offsetX-offsetY.html#L40

> // dispatchEvent(639, 316, 'in-columns', 173, -172);  // This is buggy. See https://bugs.webkit.org/show_bug.cgi?id=21993

I updated the test because the bug is now fixed. It looks correct in a WebKit nightly.
I don't know how this can be affected with different fonts on different platforms
but it looks like multi-column text is more consistent now. The hit-test of a <span>
in columns works as expected.
Comment 1 Joseph Pecoraro 2011-01-18 15:57:07 PST
Created attachment 79346 [details]
[PATCH] Update Test
Comment 2 WebKit Commit Bot 2011-01-19 06:39:54 PST
Comment on attachment 79346 [details]
[PATCH] Update Test

Clearing flags on attachment: 79346

Committed r76124: <http://trac.webkit.org/changeset/76124>
Comment 3 WebKit Commit Bot 2011-01-19 06:39:58 PST
All reviewed patches have been landed.  Closing bug.