RESOLVED FIXED 52661
[chromium] simplify complex text code, fixing a handful of layout tests 
https://bugs.webkit.org/show_bug.cgi?id=52661
Summary [chromium] simplify complex text code, fixing a handful of layout tests
Evan Martin
Reported 2011-01-18 13:50:47 PST
[chromium] simplify complex text code, fixing a handful of layout tests
Attachments
Patch (17.03 KB, patch)
2011-01-18 13:55 PST, Evan Martin 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Evan Martin
Comment 1 2011-01-18 13:55:06 PST
Created attachment 79322 [details] Patch
Evan Martin
Comment 2 2011-01-18 14:27:45 PST
With this patch, I can now select text on http://tanzil.net/ with fewer gaps in the highlighting.
Tony Chang
Comment 3 2011-01-18 15:47:43 PST
Comment on attachment 79322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79322&action=review > Source/WebCore/platform/graphics/chromium/FontLinux.cpp:212 > + // FIXME: this causes us to shape the text twice -- once to compute the width and then again > + // below when actually rendering. Change ComplexTextController to match platform/mac and > + // platform/chromium/win by having it store the shaped runs, so we can reuse the results. This is my only concern with this patch but evan said he would (1) watch the intl page cycler bots for regressions and (2) work on trying to clean this up so we don't have to shave the text twice (perhaps by doing what Windows does).
Evan Martin
Comment 4 2011-01-19 10:29:26 PST
Committed r76137: <http://trac.webkit.org/changeset/76137>
Note You need to log in before you can comment on or make changes to this bug.