Bug 52650 - make file expansion use the file at the svn revision the diff was created at
Summary: make file expansion use the file at the svn revision the diff was created at
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-18 12:47 PST by Ojan Vafai
Modified: 2011-01-18 16:30 PST (History)
4 users (show)

See Also:


Attachments
Patch (3.07 KB, patch)
2011-01-18 12:48 PST, Ojan Vafai
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2011-01-18 12:47:48 PST
make file expansion use the file at the svn revision the diff was created at
Comment 1 Ojan Vafai 2011-01-18 12:48:39 PST
Created attachment 79310 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-01-18 15:26:47 PST
Comment on attachment 79310 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=79310&action=review

Looks good though.

> Websites/bugs.webkit.org/code-review.js:424
> +    var suffix = revision ? '?p=' + revision : '';

suffix seems a bit odd for a name here.  You're constructing a query, with a single p= parameter.
Comment 3 Ojan Vafai 2011-01-18 16:30:27 PST
Committed r76082: <http://trac.webkit.org/changeset/76082>