Bug 52646 - Implement NPN_PopUpContextMenu
Summary: Implement NPN_PopUpContextMenu
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-18 12:01 PST by Anders Carlsson
Modified: 2011-01-18 12:09 PST (History)
0 users

See Also:

Attachments
Patch (5.21 KB, patch)
2011-01-18 12:05 PST, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-01-18 12:01:45 PST 
Implement NPN_PopUpContextMenu
Comment 1 Anders Carlsson 2011-01-18 12:05:04 PST 
Created attachment 79304 [details]
Patch
Comment 2 Sam Weinig 2011-01-18 12:07:56 PST 
Comment on attachment 79304 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=79304&action=review

> Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:209
> +    NPCocoaEvent *m_currentMouseEvent;

* on the wrong side. Or at least, I think it is, assuming NPCocoaEvent is no an objective-c object.

> Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:492
> +            NPCocoaEvent *previousMouseEvent = m_currentMouseEvent;

* on wrong side.
Comment 3 Anders Carlsson 2011-01-18 12:09:15 PST 
Committed r76043: <http://trac.webkit.org/changeset/76043>