Source/WebCore/thirdparty contains third-party code which does not follow WebKit coding style. check-webkit-style should skip it. (See https://bugs.webkit.org/show_bug.cgi?id=52627 for false positives.)
I'm happy to r+ a change Tools/Scripts/webkitpy/style/checker.py to make this happen :)
Created attachment 79487 [details] Patch
Comment on attachment 79487 [details] Patch You may want to just make the "-" (which should get rid of all rules if that's what is desired) instead of "-whitespace".
Comment on attachment 79487 [details] Patch Skipping whitespace is good enough to pass everything for now, but if we start failing other style checks we can add those as well. I'm slightly wary of skipping every single style check just in case some truly insane stuff starts getting added to WebCore/thirdparty/. We can figure it out when we see it :)
Comment on attachment 79487 [details] Patch Rejecting attachment 79487 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'bu..." exit_code: 2 Last 500 characters of output: ands failed: WebCore: CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/HTMLScriptElement.o /Projects/CommitQueue/Source/WebCore/html/HTMLScriptElement.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/HTMLSelectElement.o /Projects/CommitQueue/Source/WebCore/html/HTMLSelectElement.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 (2 failures) Full output: http://queues.webkit.org/results/7561236
Comment on attachment 79487 [details] Patch This patch can't have caused a compile error. Very strange.
I think I was running too many bots on the machine: /Projects/CommitQueue/Source/WebCore/html/HTMLScriptElement.cpp -o /Projects/CommitQueue/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/HTMLScriptElement.o /Developer/usr/bin/../libexec/gcc/i686-apple-darwin10/4.2.1/as: can't fork a new process to execute: /Developer/usr/bin/../libexec/gcc/darwin/x86_64/as (Resource temporarily unavailable) /Projects/CommitQueue/Source/WebCore/html/HTMLScriptElement.cpp:181: fatal error: error writing to -: Broken pipe compilation terminated.
====================================================================== ERROR: test_path_rules_specifier (webkitpy.style.checker_unittest.GlobalVariablesTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Projects/CommitQueue/Tools/Scripts/webkitpy/style/checker_unittest.py", line 197, in test_path_rules_specifier validate_filter_rules(path_rules, self._all_categories()) File "/Projects/CommitQueue/Tools/Scripts/webkitpy/style/filter.py", line 45, in validate_filter_rules "must start with + or -." % rule) ValueError: Invalid filter rule "w": every rule must start with + or -. ---------------------------------------------------------------------- Ran 804 tests in 10.609s
Comment on attachment 79487 [details] Patch You need a comma on line 165 after the ] or else python will interpret the () as a grouping instead of a list since there is only one item in the list.
Comment on attachment 79487 [details] Patch Clearing review flag on this old patch that was rejected by commit-queue.