Bug 52599 - UIProcess crash in WebPageProxy::reattachToWebProcess when web process crashes with an empty, new window.
Summary: UIProcess crash in WebPageProxy::reattachToWebProcess when web process crashe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-01-17 15:07 PST by Brady Eidson
Modified: 2011-01-18 17:47 PST (History)
1 user (show)

See Also:

Attachments
Patch v1 (1.32 KB, patch)
2011-01-18 17:43 PST, Brady Eidson 		darin: review+
beidson: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2011-01-17 15:07:37 PST 
UIProcess crash in WebPageProxy::reattachToWebProcess when web process crashes with an empty, new window.

In radar as <rdar://problem/8860833>

Windows backtrace (but can repro on Mac as well)
>	WebKit.dll!WebKit::WebPageProxy::reattachToWebProcessWithItem(WebKit::WebBackForwardListItem * item=0x00000000)  Line 226	C++
 	WebKit.dll!WebKit::WebPageProxy::reload(bool reloadFromOrigin=false)  Line 372	C++
 	WebKit.dll!WKPageReload(const OpaqueWKPage * pageRef=0x7f84db80)  Line 88	C++
 	Safari.dll!Safari::BrowserContentViewController::reload()  Line 2307 + 0x19 bytes	C++
 	Safari.dll!Safari::BrowserPageLoaderClient::processDidExit(const Safari::WK::Page & page=0x7f84db80)  Line 431 + 0x8 bytes	C++
 	Safari.dll!Safari::WK::processDidExit(const OpaqueWKPage * pageRef=0x7f84db80, const void * clientInfo=0x7f848cf0)  Line 206	C++
 	WebKit.dll!WebKit::WebPageProxy::processDidCrash()  Line 2201 + 0xe bytes	C++
 	WebKit.dll!WebKit::WebProcessProxy::didClose(CoreIPC::Connection * __formal=0x7ff39200)  Line 303 + 0x8 bytes	C++
 	WebKit.dll!CoreIPC::Connection::dispatchConnectionDidClose()  Line 357
Comment 1 Brady Eidson 2011-01-18 17:42:11 PST 
Happens on Mac, too.  And happens anytime the WebProcess crashes before it's notified the UIProcess of the current item in a new frame.

Null-check should suffice.
Comment 2 Brady Eidson 2011-01-18 17:43:57 PST 
Created attachment 79370 [details]
Patch v1
Comment 3 Brady Eidson 2011-01-18 17:47:08 PST 
r76089