Crash beneath PlatformCALayer::adoptSublayers when switching out of tiling mode (null-dereference of a PlatformCALayer)
Created attachment 79217 [details] Patch
Looks good. r=me > LayoutTests/ChangeLog:12 > + Reviewed by NOBODY (OOPS!). How come this is below the description? > Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp:688 > + for (int i = 0; i < sublayers.size(); ++i) Would it be any more efficient here to use 'n', since you have to get it anyway? Also, ASSERT(n == sublayers.size()) would be nice
(In reply to comment #2) > > > LayoutTests/ChangeLog:12 > > + Reviewed by NOBODY (OOPS!). > > How come this is below the description? Because I think it's less important than the description, in most cases. But I should email webkit-dev about changing our tools to use this alternate ordering rather than going against the flow. > > Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp:688 > > + for (int i = 0; i < sublayers.size(); ++i) > > Would it be any more efficient here to use 'n', since you have to get it anyway? I guess so. > Also, ASSERT(n == sublayers.size()) would be nice Good idea. I'll add that. Thanks for reviewing! (You, too, Darin!)
Committed r75985: <http://trac.webkit.org/changeset/75985>