RESOLVED FIXED 52584
Web Inspector: unify image data source assignment, add image url to the image view properties list. 
https://bugs.webkit.org/show_bug.cgi?id=52584
Summary Web Inspector: unify image data source assignment, add image url to the image...
Pavel Feldman
Reported 2011-01-17 09:40:12 PST
Patch to follow.
Attachments
[PATCH] Proposed change. (5.58 KB, patch)
2011-01-17 09:42 PST, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-01-17 09:42:51 PST
Created attachment 79182 [details] [PATCH] Proposed change.
Pavel Feldman
Comment 2 2011-01-17 09:51:56 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebCore/ChangeLog M Source/WebCore/English.lproj/localizedStrings.js M Source/WebCore/inspector/front-end/ImageView.js M Source/WebCore/inspector/front-end/NetworkPanel.js M Source/WebCore/inspector/front-end/Resource.js M Source/WebCore/inspector/front-end/ResourcesPanel.js Committed r75952
Andrey Kosyakov
Comment 3 2011-01-17 11:41:38 PST
Comment on attachment 79182 [details] [PATCH] Proposed change. View in context: https://bugs.webkit.org/attachment.cgi?id=79182&action=review > Source/WebCore/inspector/front-end/NetworkPanel.js:1422 > + this._resource.populateImageSource(imagePreviewElement); imagePreviewElement is not defined here. Was this change ever tested?
Pavel Feldman
Comment 4 2011-01-17 12:17:32 PST
(In reply to comment #3) > (From update of attachment 79182 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=79182&action=review > > > Source/WebCore/inspector/front-end/NetworkPanel.js:1422 > > + this._resource.populateImageSource(imagePreviewElement); > > imagePreviewElement is not defined here. Was this change ever tested? Sorry about that - too many changes today. Fixed in r75964.
Note You need to log in before you can comment on or make changes to this bug.