RESOLVED FIXED 52574
Web Inspector: restore agents' state upon frontend reuse. 
https://bugs.webkit.org/show_bug.cgi?id=52574
Summary Web Inspector: restore agents' state upon frontend reuse.
Pavel Feldman
Reported 2011-01-17 07:08:21 PST
Sometimes, we'd like to connect existing front-end to the existing inspector. We should restore agents state in the front-end in theses cases: dom, network, database, etc.
Attachments
[PATCH] Proposed change. (9.69 KB, patch)
2011-01-17 07:11 PST, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-01-17 07:11:34 PST
Created attachment 79166 [details] [PATCH] Proposed change.
Yury Semikhatsky
Comment 2 2011-01-17 07:58:09 PST
Comment on attachment 79166 [details] [PATCH] Proposed change. View in context: https://bugs.webkit.org/attachment.cgi?id=79166&action=review > Source/WebCore/inspector/Inspector.idl:-188 > - [notify, domain=DOM] void didCommitLoad(); This method should be deleted from the front-end as well. > Source/WebCore/inspector/front-end/inspector.js:1657 > + this.networkManager.reset(); Why not move this call inside WebInspector.reset ?
Pavel Feldman
Comment 3 2011-01-17 08:43:17 PST
(In reply to comment #2) > (From update of attachment 79166 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=79166&action=review > > > Source/WebCore/inspector/Inspector.idl:-188 > > - [notify, domain=DOM] void didCommitLoad(); > > This method should be deleted from the front-end as well. > Done. > > Source/WebCore/inspector/front-end/inspector.js:1657 > > + this.networkManager.reset(); > > Why not move this call inside WebInspector.reset ? We'll need a better fix for that: WebInspector.reset should not lead to cached resource query (which network manager would do upon the call). Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebCore/ChangeLog M Source/WebCore/inspector/Inspector.idl M Source/WebCore/inspector/InspectorController.cpp M Source/WebCore/inspector/InspectorController.h M Source/WebCore/inspector/front-end/DOMAgent.js M Source/WebCore/inspector/front-end/NetworkManager.js M Source/WebCore/inspector/front-end/NetworkPanel.js M Source/WebCore/inspector/front-end/ResourceTreeModel.js M Source/WebCore/inspector/front-end/ResourcesPanel.js M Source/WebCore/inspector/front-end/inspector.js Committed r75949
Andrey Kosyakov
Comment 4 2011-01-17 12:41:17 PST
Comment on attachment 79166 [details] [PATCH] Proposed change. View in context: https://bugs.webkit.org/attachment.cgi?id=79166&action=review > Source/WebCore/inspector/front-end/NetworkPanel.js:819 > var resourcesToAppend = (WebInspector.mainResource.redirects || []).concat(WebInspector.mainResource); Now we re-append the main resource event if we have _preserveLogToggle.toggled and did not clear the panel in clear(). Should we?
Pavel Feldman
Comment 5 2011-01-17 12:59:55 PST
> Now we re-append the main resource event if we have _preserveLogToggle.toggled and did not clear the panel in clear(). Should we? Nope. r75969 has a fix. Thanks.
Note You need to log in before you can comment on or make changes to this bug.