Bug 52571 – [Qt] Fixed compilation with QT_NO_GRAPHICSVIEW

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebKit Qt

[Konstantin Tokarev]

This patch fixes compilation of QtWebKit when QGraphicsView is disabled in Qt configuration

[Konstantin Tokarev]

Created attachment 79161 [details]
Fixed compilation with QT_NO_GRAPHICSVIEW

[Laszlo Gombos]

This seems like a DUP of bug 49750. 

Konstantin, do you have ACCELERATED_COMPOSITING enabled ?

[Konstantin Tokarev]

>This seems like a DUP of bug 49750

Maybe. 

BTW, trunk still does not compile without this patch. Should I relocate it?

>Konstantin, do you have ACCELERATED_COMPOSITING enabled ?

Yes, it's enabled. However, I don't understand how can I manage it :)

[Laszlo Gombos]

(In reply to comment #3)
> >This seems like a DUP of bug 49750
> 
> Maybe. 
> 
> BTW, trunk still does not compile without this patch. Should I relocate it?
> 
> >Konstantin, do you have ACCELERATED_COMPOSITING enabled ?
> 
> Yes, it's enabled. However, I don't understand how can I manage it :)

Perhaps ACCELERATED_COMPOSITING should not be enabled (and than the stub in GraphicsLayerQt.cpp is not needed).

Can you try the last patch attached to bug 4975 (https://bug-49750-attachments.webkit.org/attachment.cgi?id=79124). If it works I think we think we should mark this bug a DUP of 49750.

The path at bug 49750 disables ACCELERATED_COMPOSITING (unless Texture Mapper is turned on).

[Konstantin Tokarev]

(In reply to comment #4)
> (In reply to comment #3)
> > >This seems like a DUP of bug 49750
> > 
> > Maybe. 
> > 
> > BTW, trunk still does not compile without this patch. Should I relocate it?
> > 
> > >Konstantin, do you have ACCELERATED_COMPOSITING enabled ?
> > 
> > Yes, it's enabled. However, I don't understand how can I manage it :)
> 
> Perhaps ACCELERATED_COMPOSITING should not be enabled (and than the stub in GraphicsLayerQt.cpp is not needed).
> 
> Can you try the last patch attached to bug 4975 (https://bug-49750-attachments.webkit.org/attachment.cgi?id=79124). If it works I think we think we should mark this bug a DUP of 49750.
> 
> The path at bug 49750 disables ACCELERATED_COMPOSITING (unless Texture Mapper is turned on).

I've applied that path. Nevertheless, I get ACCELERATED_COMPOSITING enabled in Platform.h

PLATFORM(QT) && (!defined(QT_NO_GRAPHICSVIEW) || USE(TEXTURE_MAPPER))

In my case, QT_NO_GRAPHICSVIEW is not defined here. Seems like no Qt headers were included

[Eric Seidel (no email)]

Comment on attachment 79161 [details]
Fixed compilation with QT_NO_GRAPHICSVIEW

Seems kinda hacky.  Does this work?

[Benjamin Poulain]

Comment on attachment 79161 [details]
Fixed compilation with QT_NO_GRAPHICSVIEW

Graphic layer is a concept of accelerated compositing. Accelerated compositing rely on QGraphicsView if you do not use texture mapper.

Having accelerated compositing without QGraphicsView and without texture mapper should not be supported IMHO.

[Csaba Osztrogonác]

Closing bug, based on Benjamin's comment.