Bug 52566 - Add myself to committers list
Summary: Add myself to committers list
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: John Knottenbelt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-17 04:27 PST by John Knottenbelt
Modified: 2011-03-18 08:53 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.48 KB, patch)
2011-01-17 04:28 PST, John Knottenbelt
no flags Details | Formatted Diff | Diff
Patch (1.47 KB, patch)
2011-01-17 04:55 PST, John Knottenbelt
no flags Details | Formatted Diff | Diff
Patch (1.57 KB, patch)
2011-03-18 08:43 PDT, John Knottenbelt
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Knottenbelt 2011-01-17 04:27:41 PST
Add myself to committers list
Comment 1 John Knottenbelt 2011-01-17 04:28:50 PST
Created attachment 79151 [details]
Patch
Comment 2 John Knottenbelt 2011-01-17 04:55:34 PST
Created attachment 79155 [details]
Patch
Comment 3 Csaba Osztrogonác 2011-01-17 14:00:27 PST
Comment on attachment 79155 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=79155&action=review

> Tools/Scripts/webkitpy/common/config/committers.py:138
> +    Committer("John Knottenbelt", ["jknotten@chromium.org"], "jknotten"),

Committer("John Knottenbelt", "jknotten@chromium.org", "jknotten"),

You don't need [ ... ] if you only add only one e-mail address. Additionally this 
patch doesn't need a review, but if you would like it, rs=me with this change.
Comment 4 John Knottenbelt 2011-03-18 08:43:07 PDT
Created attachment 86168 [details]
Patch
Comment 5 John Knottenbelt 2011-03-18 08:51:53 PDT
Committed r81474: <http://trac.webkit.org/changeset/81474>