Bug 52557 - <keygen> presents itself as a HTMLSelectElement to script
Summary: <keygen> presents itself as a HTMLSelectElement to script
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 51379 52787
  Show dependency treegraph
 
Reported: 2011-01-17 00:20 PST by Dominic Cooney
Modified: 2011-01-21 08:51 PST (History)
10 users (show)

See Also:


Attachments
Patch (34.92 KB, patch)
2011-01-17 00:30 PST, Dominic Cooney
no flags Details | Formatted Diff | Diff
Patch (34.95 KB, patch)
2011-01-17 01:04 PST, Dominic Cooney
no flags Details | Formatted Diff | Diff
Syncs to head and makes GTK build. (35.54 KB, patch)
2011-01-18 20:21 PST, Dominic Cooney
tkent: review+
tkent: commit-queue+
Details | Formatted Diff | Diff
Patch (35.62 KB, patch)
2011-01-19 22:01 PST, Dominic Cooney
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dominic Cooney 2011-01-17 00:20:50 PST
Instead of implementing the HTMLKeygenElement object model <http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#the-keygen-element>, <keygen> elements appear to be HTMLSelectElements to script (for example their constructor is HTMLSelectElementConstructor; they have an options collection; etc.)
Comment 1 Dominic Cooney 2011-01-17 00:30:17 PST
Created attachment 79137 [details]
Patch
Comment 2 Dominic Cooney 2011-01-17 01:04:11 PST
Created attachment 79138 [details]
Patch

Syncs to head.
Comment 3 Dimitri Glazkov (Google) 2011-01-17 09:07:39 PST
Comment on attachment 79138 [details]
Patch

Looks great.
Comment 4 WebKit Commit Bot 2011-01-17 18:23:51 PST
Comment on attachment 79138 [details]
Patch

Rejecting attachment 79138 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'apply-..." exit_code: 2

Last 500 characters of output:
dings/gobject/GNUmakefile.am
patching file Source/WebCore/bindings/gobject/WebKitHTMLElementWrapperFactory.cpp
patching file Source/WebCore/bindings/objc/DOM.mm
patching file Source/WebCore/html/HTMLKeygenElement.h
patching file Source/WebCore/html/HTMLKeygenElement.idl
patching file Source/WebCore/html/HTMLTagNames.in
patching file Source/WebCore/page/DOMWindow.idl

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Dimitri Glazkov', u'--..." exit_code: 1

Full output: http://queues.webkit.org/results/7549177
Comment 5 WebKit Review Bot 2011-01-17 19:21:30 PST
Attachment 79138 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/7515176
Comment 6 Kent Tamura 2011-01-17 19:36:01 PST
Possible conflict and a GTK build error.  Please update the patch.
Comment 7 Dominic Cooney 2011-01-18 20:21:06 PST
Created attachment 79387 [details]
Syncs to head and makes GTK build.
Comment 8 WebKit Commit Bot 2011-01-19 17:45:21 PST
Comment on attachment 79387 [details]
Syncs to head and makes GTK build.

Rejecting attachment 79387 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-..." exit_code: 2

Last 500 characters of output:
hing file Source/WebCore/bindings/objc/DOM.mm
patching file Source/WebCore/html/HTMLKeygenElement.h
Hunk #1 FAILED at 32.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/html/HTMLKeygenElement.h.rej
patching file Source/WebCore/html/HTMLKeygenElement.idl
patching file Source/WebCore/html/HTMLTagNames.in
patching file Source/WebCore/page/DOMWindow.idl

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Dimitri Glazkov', u'--..." exit_code: 1

Full output: http://queues.webkit.org/results/7600223
Comment 9 Dominic Cooney 2011-01-19 22:01:20 PST
Created attachment 79552 [details]
Patch
Comment 10 Kent Tamura 2011-01-19 22:06:44 PST
Comment on attachment 79387 [details]
Syncs to head and makes GTK build.

View in context: https://bugs.webkit.org/attachment.cgi?id=79387&action=review

> Source/WebCore/ChangeLog:13
> +        Make <keygen> no longer appear to be a <select> element to script.
> +
> +        The intent is to put <keygen> options into shadow DOM. This change
> +        takes the first step by hiding the <select> element from
> +        JavaScript.
> +
> +        Test: fast/dom/HTMLKeygenElement/keygen.html
> +
> +        https://bugs.webkit.org/show_bug.cgi?id=52557

nit: We usually use the following format:

    <summary>
    <bug URL>

    <description>

    Test: <test names>
Comment 11 WebKit Commit Bot 2011-01-19 22:10:13 PST
Comment on attachment 79552 [details]
Patch

Rejecting attachment 79552 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-sf-cq', 'ap..." exit_code: 2

Last 500 characters of output:
ore/bindings/gobject/GNUmakefile.am
patching file Source/WebCore/bindings/gobject/WebKitHTMLElementWrapperFactory.cpp
patching file Source/WebCore/bindings/objc/DOM.mm
patching file Source/WebCore/html/HTMLKeygenElement.h
patching file Source/WebCore/html/HTMLKeygenElement.idl
patching file Source/WebCore/html/HTMLTagNames.in
patching file Source/WebCore/page/DOMWindow.idl

Failed to run "[u'/Projects/CommitQueue/Tools/Scripts/svn-apply', u'--reviewer', u'Kent Tamura', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/7544229
Comment 12 Kent Tamura 2011-01-19 22:36:10 PST
Landed manually: http://trac.webkit.org/changeset/76208
Comment 13 WebKit Review Bot 2011-01-19 23:16:17 PST
http://trac.webkit.org/changeset/76208 might have broken Qt Linux Release
The following tests are not passing:
fast/dom/Window/window-properties.html
fast/dom/Window/window-property-descriptors.html
fast/dom/prototype-inheritance.html
fast/js/global-constructors.html
Comment 14 Eric Seidel (no email) 2011-01-19 23:19:57 PST
Why are these results forked for Qt?  We should find a way to make that not be the case, otherwise everyone is going to break them all the time.
Comment 15 Jessie Berlin 2011-01-21 08:35:28 PST
(In reply to comment #12)
> Landed manually: http://trac.webkit.org/changeset/76208

I will be adding the Windows-specific results for 

fast/dom/prototype-inheritance-2.html
fast/dom/prototype-inheritance.html
fast/dom/Window/window-property-descriptors.html
fast/js/global-constructors.html

shortly in order to get the bots green. I am not sure why we have windows-specific results for these tests, and I will look into why we do after I get the bots green.
Comment 16 Jessie Berlin 2011-01-21 08:42:49 PST
(In reply to comment #15)
> (In reply to comment #12)
> > Landed manually: http://trac.webkit.org/changeset/76208
> 
> I will be adding the Windows-specific results for 
> 
> fast/dom/prototype-inheritance-2.html
> fast/dom/prototype-inheritance.html
> fast/dom/Window/window-property-descriptors.html
> fast/js/global-constructors.html
> 
> shortly in order to get the bots green. I am not sure why we have windows-specific results for these tests, and I will look into why we do after I get the bots green.

Adam Roben mentioned that this is probably related to Dashboard regions, which are a Mac-only feature. That would also explain the different results for Qt.
Comment 17 Jessie Berlin 2011-01-21 08:51:03 PST
Submitted the modified Windows 7 results in http://trac.webkit.org/changeset/76350