Bug 52553 – [GTK] Many DOM XHTML tests time out

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Martin Robinson]

Many tests in the dom/xhtml/level3/core/ directory seem to time out. From initial examination, the issue seems to be that the soup backend does not handle the failure of a synchronous load before the inner event loop has started.

[Martin Robinson]

Created attachment 79129 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 79129 [details]
Patch

Can't we run the loop with a timeout?  Or schedule a timeout event on the loop before we run it?  That seems like a more general fix for this problem than this specific exclusion.

[Martin Robinson]

(In reply to comment #2)
> (From update of attachment 79129 [details])
> Can't we run the loop with a timeout?  Or schedule a timeout event on the loop before we run it?  That seems like a more general fix for this problem than this specific exclusion.

I had considered a solution like this, but the details of the operation of the WebCoreSynchronousLoader are hidden from ResourceHandle::loadResourceSynchronously. Meanwhile, the handle itself "owns" the WebCoreSynchronousLoader (it's the client), so it didn't seem clean to add another relationship. I finally chose this approach because it matches the CF network code.

[Martin Robinson]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 79129 [details] [details])
> > Can't we run the loop with a timeout?  Or schedule a timeout event on the loop before we run it?  That seems like a more general fix for this problem than this specific exclusion.
> 
> I had considered a solution like this, but the details of the operation of the WebCoreSynchronousLoader are hidden from ResourceHandle::loadResourceSynchronously. Meanwhile, the handle itself "owns" the WebCoreSynchronousLoader (it's the client), so it didn't seem clean to add another relationship. I finally chose this approach because it matches the CF network code.

By the way, thanks for the review!

[Martin Robinson]

Comment on attachment 79129 [details]
Patch

Clearing flags on attachment: 79129

Committed r76555: <http://trac.webkit.org/changeset/76555>

[Martin Robinson]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/76555 might have broken GTK Linux 32-bit Release
The following tests are not passing:
http/tests/xmlhttprequest/simple-cross-origin-denied-events-post.html
http/tests/xmlhttprequest/simple-cross-origin-denied-events-sync.html
media/unsupported-rtsp.html