Bug 52532 – Web Inspector: make WebCore use InspectorInstrumentation for instrumentation calls.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Patch to follow.

[Pavel Feldman]

Created attachment 79109 [details]
[PATCH] Proposed change

[Yury Semikhatsky]

Comment on attachment 79109 [details]
[PATCH] Proposed change

View in context: https://bugs.webkit.org/attachment.cgi?id=79109&action=review

> Source/WebCore/inspector/InspectorController.cpp:151
> +    InspectorInstrumentation::inspectorControllerCreated(page, this);

I'd rather declare a friend function that would get InspectorAgent from Page.

> Source/WebCore/inspector/InspectorInstrumentation.h:893
> +        return inspectorControllerWithFrontendForPage(static_cast<Document*>(context)->page());

Should return IC even if there is no FE

> Source/WebCore/inspector/InspectorInstrumentation.h:915
> +        return inspectorControllerForContext(context);

Please check that the IC has FE

[Pavel Feldman]

Created attachment 79145 [details]
[PATCH] Review comments addressed.

[Pavel Feldman]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebCore/ChangeLog
	M	Source/WebCore/dom/Document.cpp
	M	Source/WebCore/dom/Document.h
	M	Source/WebCore/dom/ScriptExecutionContext.h
	M	Source/WebCore/inspector/InspectorBrowserDebuggerAgent.cpp
	M	Source/WebCore/inspector/InspectorBrowserDebuggerAgent.h
	M	Source/WebCore/inspector/InspectorConsoleAgent.cpp
	M	Source/WebCore/inspector/InspectorConsoleAgent.h
	M	Source/WebCore/inspector/InspectorController.cpp
	M	Source/WebCore/inspector/InspectorController.h
	M	Source/WebCore/inspector/InspectorDOMAgent.h
	M	Source/WebCore/inspector/InspectorDOMStorageAgent.h
	M	Source/WebCore/inspector/InspectorDatabaseAgent.cpp
	M	Source/WebCore/inspector/InspectorDatabaseAgent.h
	M	Source/WebCore/inspector/InspectorFrontendHost.cpp
	M	Source/WebCore/inspector/InspectorFrontendHost.h
	M	Source/WebCore/inspector/InspectorInstrumentation.cpp
	M	Source/WebCore/inspector/InspectorInstrumentation.h
	M	Source/WebCore/inspector/InspectorState.cpp
	M	Source/WebCore/loader/FrameLoader.cpp
	M	Source/WebCore/page/Chrome.cpp
	M	Source/WebCore/page/Console.cpp
	M	Source/WebCore/page/DOMWindow.cpp
	M	Source/WebCore/page/EventHandler.cpp
	M	Source/WebCore/page/Page.cpp
	M	Source/WebCore/storage/Database.cpp
	M	Source/WebCore/workers/AbstractWorker.cpp
	M	Source/WebCore/workers/SharedWorker.cpp
	M	Source/WebCore/workers/Worker.cpp
	M	Source/WebCore/workers/WorkerMessagingProxy.cpp
Committed r75932