Bug 52530 - Move WebKit into Source
Summary: Move WebKit into Source
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 51606
  Show dependency treegraph
 
Reported: 2011-01-16 02:15 PST by Adam Barth
Modified: 2011-01-16 21:02 PST (History)
5 users (show)

See Also:


Attachments
Patch (114.45 KB, patch)
2011-01-16 02:16 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Downstream patch for Chromium (10.33 KB, patch)
2011-01-16 02:59 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (114.48 KB, patch)
2011-01-16 15:31 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-01-16 02:15:35 PST
Move WebKit into Source
Comment 1 Adam Barth 2011-01-16 02:16:30 PST
Created attachment 79093 [details]
Patch
Comment 2 WebKit Review Bot 2011-01-16 02:18:58 PST
Attachment 79093 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Android.mk', u'CMakeLists.txt', u'ChangeLo..." exit_code: 1

Tools/QtTestBrowser/launcherwindow.h:70:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 48 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Review Bot 2011-01-16 02:19:22 PST
Attachment 79093 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7532114
Comment 4 Early Warning System Bot 2011-01-16 02:22:00 PST
Attachment 79093 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7507112
Comment 5 Adam Barth 2011-01-16 02:22:53 PST
EWS failures expected because this patch doesn't include the actual move.  We'll also need (at least) this patch downstream for Chromium.

Index: glue/webkit_glue.gypi
===================================================================
--- glue/webkit_glue.gypi    (revision 71432)
+++ glue/webkit_glue.gypi    (working copy)
@@ -6,7 +6,7 @@
   'variables': {
     'conditions': [
       ['inside_chromium_build==0', {
-        'webkit_src_dir': '../../../..',
+        'webkit_src_dir': '../../../../..',
       },{
         'webkit_src_dir': '../../third_party/WebKit',
       }],
@@ -45,7 +45,7 @@
         {
           'action_name': 'webkit_chromium_resources',
           'variables': {
-            'input_path': '<(webkit_src_dir)/WebKit/chromium/WebKit.grd',
+            'input_path': '<(webkit_src_dir)/Source/WebKit/chromium/WebKit.grd',
           },
           'inputs': [
             '<!@(<(grit_info_cmd) --inputs <(input_path))',
@@ -512,11 +512,11 @@
           'conditions': [
             ['inside_chromium_build==1 and component=="shared_library"', {
               'dependencies': [
-                '<(DEPTH)/third_party/WebKit/WebKit/chromium/WebKit.gyp:webkit',
+                '<(DEPTH)/third_party/WebKit/Source/WebKit/chromium/WebKit.gyp:webkit',
                 '<(DEPTH)/v8/tools/gyp/v8.gyp:v8',
                ],
                'export_dependent_settings': [
-                 '<(DEPTH)/third_party/WebKit/WebKit/chromium/WebKit.gyp:webkit',
+                 '<(DEPTH)/third_party/WebKit/Source/WebKit/chromium/WebKit.gyp:webkit',
                  '<(DEPTH)/v8/tools/gyp/v8.gyp:v8',
                ],
             }],
Comment 6 Build Bot 2011-01-16 02:34:53 PST
Attachment 79093 [details] did not build on win:
Build output: http://queues.webkit.org/results/7583121
Comment 7 Adam Barth 2011-01-16 02:59:44 PST
Created attachment 79094 [details]
Downstream patch for Chromium

This is a more complete downstream patch for Chromium.  The real downstream patch is actually larger.  We need to update the root DEPS and adjust a bunch of include directives in source files.
Comment 8 Adam Barth 2011-01-16 03:02:22 PST
This move is by far the most complex.  I'm going to leave this patch up here for a bit to see if folks have comments before actually landing it.  (Note: the attached patch doesn't actually move the directory---if you want to try it, you'll have to do the move manually.)
Comment 9 Csaba Osztrogonác 2011-01-16 05:35:05 PST
Comment on attachment 79093 [details]
Patch

I tested this patch, Qt build is OK.
Comment 10 Adam Barth 2011-01-16 10:50:46 PST
> I tested this patch, Qt build is OK.

Thanks!
Comment 11 Xan Lopez 2011-01-16 11:45:46 PST
Comment on attachment 79093 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=79093&action=review

Builds fine in GTK+ with the following typos fixed.

> GNUmakefile.am:236
> +include SOurce/WebKit/gtk/po/GNUmakefile.am

Type, SOurce.

> WebKit/gtk/GNUmakefile.am:432
> +Programs_unittests_testdomdocument_SOURCES = Soource/WebKit/gtk/tests/testdomdocument.c

Type, Soource.
Comment 12 Xan Lopez 2011-01-16 11:50:04 PST
I can't believe I wrote 'Type' twice there...
Comment 13 Adam Barth 2011-01-16 15:30:14 PST
> Builds fine in GTK+ with the following typos fixed.

Thanks for trying it out.  Issues fixed.
Comment 14 Adam Barth 2011-01-16 15:31:21 PST
Created attachment 79116 [details]
Patch
Comment 15 WebKit Review Bot 2011-01-16 15:34:28 PST
Attachment 79116 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Android.mk', u'CMakeLists.txt', u'ChangeLo..." exit_code: 1

Tools/QtTestBrowser/launcherwindow.h:70:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 48 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 16 WebKit Review Bot 2011-01-16 15:45:05 PST
Attachment 79116 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7525144
Comment 17 Early Warning System Bot 2011-01-16 15:48:34 PST
Attachment 79116 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7495148
Comment 18 Build Bot 2011-01-16 15:53:35 PST
Attachment 79116 [details] did not build on win:
Build output: http://queues.webkit.org/results/7572126
Comment 19 Adam Barth 2011-01-16 21:02:29 PST
Committed r75908: <http://trac.webkit.org/changeset/75908>