Bug 52489 - GraphicsLayers in subframes can get sync'd multiple times
Summary: GraphicsLayers in subframes can get sync'd multiple times
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-14 15:32 PST by Simon Fraser (smfr)
Modified: 2011-07-21 18:02 PDT (History)
4 users (show)

See Also:

Attachments
Preliminary cleanup. (11.08 KB, text/plain)
2011-01-19 18:24 PST, Simon Fraser (smfr) 		no flags Details
Patch (13.61 KB, text/plain)
2011-01-19 18:50 PST, Simon Fraser (smfr) 		no flags Details
Patch (6.92 KB, patch)
2011-07-21 15:30 PDT, Simon Fraser (smfr) 		jamesr: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2011-01-14 15:32:05 PST 
FrameView::syncCompositingStateRecursive() calls sync on the root GraphicsLayer each frame, so when compositing layers are connected between frames, we'll end up syncing subframe's layers multiple times.
Comment 1 Simon Fraser (smfr) 2011-01-19 18:24:59 PST 
Created attachment 79535 [details]
Preliminary cleanup.
Comment 2 Early Warning System Bot 2011-01-19 18:40:52 PST 
Attachment 79535 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7498206
Comment 3 Build Bot 2011-01-19 18:46:34 PST 
Attachment 79535 [details] did not build on win:
Build output: http://queues.webkit.org/results/7507229
Comment 4 Simon Fraser (smfr) 2011-01-19 18:50:36 PST 
Created attachment 79537 [details]
Patch
Comment 5 Early Warning System Bot 2011-01-19 19:10:33 PST 
Attachment 79537 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7612226
Comment 6 Sam Weinig 2011-01-19 19:18:42 PST 
Comment on attachment 79537 [details]
Patch

Make sure to fix the Qt.
Comment 7 Simon Fraser (smfr) 2011-01-19 19:21:15 PST 
Comment on attachment 79535 [details]
Preliminary cleanup.

http://trac.webkit.org/changeset/76196
Comment 8 Simon Fraser (smfr) 2011-01-19 19:21:44 PST 
Comment on attachment 79537 [details]
Patch

Actually this one: http://trac.webkit.org/changeset/76196
Comment 9 Simon Fraser (smfr) 2011-07-21 15:30:57 PDT 
Created attachment 101651 [details]
Patch
Comment 10 James Robinson 2011-07-21 18:00:39 PDT 
Comment on attachment 101651 [details]
Patch

Cool, R=me
Comment 11 Simon Fraser (smfr) 2011-07-21 18:02:50 PDT 
http://trac.webkit.org/changeset/91542