Bug 52476 - ShouldLoadResourceForFrame should use strings, not URLs.
Summary: ShouldLoadResourceForFrame should use strings, not URLs.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Brian Weinstein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-14 13:55 PST by Brian Weinstein
Modified: 2011-04-07 11:09 PDT (History)
3 users (show)

See Also:

Attachments
[PATCH] Fix (5.61 KB, patch)
2011-01-14 14:11 PST, Brian Weinstein 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Weinstein 2011-01-14 13:55:35 PST 
ShouldLoadResourceForFrame should use strings, not URLs.
Comment 1 Brian Weinstein 2011-01-14 14:11:46 PST 
Created attachment 78997 [details]
[PATCH] Fix
Comment 2 Geoffrey Garen 2011-01-14 14:18:53 PST 
Comment on attachment 78997 [details]
[PATCH] Fix

r=me
Comment 3 Alexey Proskuryakov 2011-01-14 22:48:14 PST 
Just for the education of unwashed masses (myself) - what's the reason for this change?
Comment 4 Alexey Proskuryakov 2011-01-15 11:13:39 PST 
I can see how avoiding a string to URL conversion in injected bundle method makes a lot of sense for performance. But WebKit obviously needs a KURL when loading - can you use an existing KURL object to pass to InjectedBundlePageLoaderClient::shouldLoadResourceForFrame()?
Comment 5 Brian Weinstein 2011-04-07 11:09:54 PDT 
This was landed in r75826.