WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
52476
ShouldLoadResourceForFrame should use strings, not URLs.
https://bugs.webkit.org/show_bug.cgi?id=52476
Summary
ShouldLoadResourceForFrame should use strings, not URLs.
Brian Weinstein
Reported
2011-01-14 13:55:35 PST
ShouldLoadResourceForFrame should use strings, not URLs.
Attachments
[PATCH] Fix
(5.61 KB, patch)
2011-01-14 14:11 PST
,
Brian Weinstein
ggaren
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Brian Weinstein
Comment 1
2011-01-14 14:11:46 PST
Created
attachment 78997
[details]
[PATCH] Fix
Geoffrey Garen
Comment 2
2011-01-14 14:18:53 PST
Comment on
attachment 78997
[details]
[PATCH] Fix r=me
Alexey Proskuryakov
Comment 3
2011-01-14 22:48:14 PST
Just for the education of unwashed masses (myself) - what's the reason for this change?
Alexey Proskuryakov
Comment 4
2011-01-15 11:13:39 PST
I can see how avoiding a string to URL conversion in injected bundle method makes a lot of sense for performance. But WebKit obviously needs a KURL when loading - can you use an existing KURL object to pass to InjectedBundlePageLoaderClient::shouldLoadResourceForFrame()?
Brian Weinstein
Comment 5
2011-04-07 11:09:54 PDT
This was landed in
r75826
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug