Bug 52460 – [Qt] Fixed compilation when QT_NO_SHORTCUT is defined

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Konstantin Tokarev]

This patch fixes compilation when QT_NO_SHORTCUT is defined in Qt configuration

[Konstantin Tokarev]

Created attachment 78964 [details]
Fixed compilation when QT_NO_SHORTCUT is defined

[Benjamin Poulain]

Please follow this to report bugs on QtWebKit: http://trac.webkit.org/wiki/QtWebKitBugs

By using the template, you get the "Qt" keyword and the bug appear in our lists.

[Benjamin Poulain]

Comment on attachment 78964 [details]
Fixed compilation when QT_NO_SHORTCUT is defined

View in context: https://bugs.webkit.org/attachment.cgi?id=78964&action=review

> WebKit/qt/ChangeLog:8
> +        This patch fixes compilation when QT_NO_SHORTCUT is defined in Qt configuration

<Kenneth>A dot at the end of the sentence!</Kenneth>

> WebKit/qt/WebCoreSupport/EditorClientQt.cpp:484
> +#ifndef QT_NO_SHORTCUT
>          }
> -
> +#endif

I would rather see 
} else
#endif // QT_NO_SHORTCUT
{
a dozen of lines above.

[Benjamin Poulain]

Adding Laszlo, he works on minimal builds.

[Konstantin Tokarev]

Created attachment 78967 [details]
Fixed compilation when QT_NO_SHORTCUT is defined

[Kenneth Rohde Christiansen]

> <Kenneth>A dot at the end of the sentence!</Kenneth>

hahaah :-) So much for enforcing the WebKit coding style! Actually it is not a real sentence without the punctuation mark at the end. :-)

[Laszlo Gombos]

Comment on attachment 78967 [details]
Fixed compilation when QT_NO_SHORTCUT is defined

LGTM, r+. Thanks.

[WebKit Commit Bot]

Comment on attachment 78967 [details]
Fixed compilation when QT_NO_SHORTCUT is defined

Clearing flags on attachment: 78967

Committed r75812: <http://trac.webkit.org/changeset/75812>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.