Bug 52458 - put remove lines to the left of add lines in sidebyside view
Summary: put remove lines to the left of add lines in sidebyside view
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-14 10:46 PST by Ojan Vafai
Modified: 2011-01-14 17:02 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.66 KB, patch)
2011-01-14 10:48 PST, Ojan Vafai 		no flags Details | Formatted Diff | Diff
Patch (3.40 KB, patch)
2011-01-14 14:38 PST, Ojan Vafai 		abarth: review+
Details | Formatted Diff | Diff
screenshot (228.55 KB, image/png)
2011-01-14 14:38 PST, Ojan Vafai 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2011-01-14 10:46:19 PST 
put remove lines to the left of add lines in sidebyside view
Comment 1 Ojan Vafai 2011-01-14 10:48:39 PST 
Created attachment 78960 [details]
Patch
Comment 2 Adam Barth 2011-01-14 13:37:29 PST 
Comment on attachment 78960 [details]
Patch

The code looks fine, but I'd like to see a screenshot.  :)
Comment 3 Ojan Vafai 2011-01-14 14:38:16 PST 
Created attachment 79002 [details]
Patch
Comment 4 Ojan Vafai 2011-01-14 14:38:42 PST 
Created attachment 79003 [details]
screenshot
Comment 5 Adam Barth 2011-01-14 16:42:05 PST 
Comment on attachment 79002 [details]
Patch

Thanks for the pretty pictures.
Comment 6 Ojan Vafai 2011-01-14 17:02:28 PST 
Committed r75845: <http://trac.webkit.org/changeset/75845>