52453 – Do some forward declaration in RenderStyle.h

RESOLVED FIXED 52453

Do some forward declaration in RenderStyle.h

https://bugs.webkit.org/show_bug.cgi?id=52453

Summary Do some forward declaration in RenderStyle.h

Tony Gentilcore

Reported 2011-01-14 09:27:57 PST

Do some forward declaration in RenderStyle.h

Attachments
Patch (24.36 KB, patch) 2011-01-14 09:30 PST, Tony Gentilcore	no flags	Details Formatted Diff Diff
Patch (23.00 KB, patch) 2011-01-14 09:36 PST, Tony Gentilcore	no flags	Details Formatted Diff Diff
Patch (26.43 KB, patch) 2011-01-14 10:32 PST, Tony Gentilcore	no flags	Details Formatted Diff Diff
Patch (27.83 KB, patch) 2011-01-14 11:08 PST, Tony Gentilcore	no flags	Details Formatted Diff Diff
Patch (29.90 KB, patch) 2011-01-14 11:58 PST, Tony Gentilcore	no flags	Details Formatted Diff Diff
Patch (30.32 KB, patch) 2011-01-14 13:06 PST, Tony Gentilcore	levin: review+	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Tony Gentilcore

Comment 1 2011-01-14 09:30:12 PST

Created attachment 78949 [details] Patch

Tony Gentilcore

Comment 2 2011-01-14 09:36:10 PST

Created attachment 78951 [details] Patch

Early Warning System Bot

Comment 3 2011-01-14 09:47:20 PST

Attachment 78949 [details] did not build on qt: Build output: http://queues.webkit.org/results/7616030

WebKit Review Bot

Comment 4 2011-01-14 09:52:21 PST

Attachment 78951 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7603049

Build Bot

Comment 5 2011-01-14 09:54:20 PST

Attachment 78949 [details] did not build on win: Build output: http://queues.webkit.org/results/7558043

WebKit Review Bot

Comment 6 2011-01-14 10:00:55 PST

Attachment 78949 [details] did not build on gtk: Build output: http://queues.webkit.org/results/7520056

Early Warning System Bot

Comment 7 2011-01-14 10:08:29 PST

Attachment 78951 [details] did not build on qt: Build output: http://queues.webkit.org/results/7506034

Build Bot

Comment 8 2011-01-14 10:11:49 PST

Attachment 78951 [details] did not build on win: Build output: http://queues.webkit.org/results/7588041

WebKit Review Bot

Comment 9 2011-01-14 10:26:10 PST

Attachment 78949 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7606037

Tony Gentilcore

Comment 10 2011-01-14 10:32:02 PST

Created attachment 78957 [details] Patch

WebKit Review Bot

Comment 11 2011-01-14 10:37:42 PST

Attachment 78951 [details] did not build on gtk: Build output: http://queues.webkit.org/results/7514038

Early Warning System Bot

Comment 12 2011-01-14 10:51:02 PST

Attachment 78957 [details] did not build on qt: Build output: http://queues.webkit.org/results/7626004

David Levin

Comment 13 2011-01-14 10:52:35 PST

Comment on attachment 78957 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78957&action=review r+ (as long as it compiles). One small nit. > Source/WebCore/rendering/style/RenderStyle.h:91 > +struct ContentData; Nit: I would put the struct into a separate grouping (like what is done in Source/WebCore/html/HTMLFormElement.h for example).

Build Bot

Comment 14 2011-01-14 11:04:43 PST

Attachment 78957 [details] did not build on win: Build output: http://queues.webkit.org/results/7549041

Tony Gentilcore

Comment 15 2011-01-14 11:08:09 PST

> r+ (as long as it compiles). The EWS bots will probably continue to find port-specific transitive deps. I won't land until they are all happy. > Nit: I would put the struct into a separate grouping (like what is done in Source/WebCore/html/HTMLFormElement.h for example). Done.

Tony Gentilcore

Comment 16 2011-01-14 11:08:14 PST

Created attachment 78966 [details] Patch

WebKit Review Bot

Comment 17 2011-01-14 11:08:18 PST

Attachment 78957 [details] did not build on gtk: Build output: http://queues.webkit.org/results/7567040

WebKit Review Bot

Comment 18 2011-01-14 11:20:56 PST

Attachment 78957 [details] did not build on mac: Build output: http://queues.webkit.org/results/7580048

WebKit Review Bot

Comment 19 2011-01-14 11:37:18 PST

Attachment 78957 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7513047