Bug 52453 - Do some forward declaration in RenderStyle.h
Summary: Do some forward declaration in RenderStyle.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Gentilcore
URL:
Keywords:
Depends on:
Blocks: 52451
  Show dependency treegraph
 
Reported: 2011-01-14 09:27 PST by Tony Gentilcore
Modified: 2011-01-14 16:38 PST (History)
8 users (show)

See Also:


Attachments
Patch (24.36 KB, patch)
2011-01-14 09:30 PST, Tony Gentilcore
no flags Details | Formatted Diff | Diff
Patch (23.00 KB, patch)
2011-01-14 09:36 PST, Tony Gentilcore
no flags Details | Formatted Diff | Diff
Patch (26.43 KB, patch)
2011-01-14 10:32 PST, Tony Gentilcore
no flags Details | Formatted Diff | Diff
Patch (27.83 KB, patch)
2011-01-14 11:08 PST, Tony Gentilcore
no flags Details | Formatted Diff | Diff
Patch (29.90 KB, patch)
2011-01-14 11:58 PST, Tony Gentilcore
no flags Details | Formatted Diff | Diff
Patch (30.32 KB, patch)
2011-01-14 13:06 PST, Tony Gentilcore
levin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Gentilcore 2011-01-14 09:27:57 PST
Do some forward declaration in RenderStyle.h
Comment 1 Tony Gentilcore 2011-01-14 09:30:12 PST
Created attachment 78949 [details]
Patch
Comment 2 Tony Gentilcore 2011-01-14 09:36:10 PST
Created attachment 78951 [details]
Patch
Comment 3 Early Warning System Bot 2011-01-14 09:47:20 PST
Attachment 78949 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7616030
Comment 4 WebKit Review Bot 2011-01-14 09:52:21 PST
Attachment 78951 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7603049
Comment 5 Build Bot 2011-01-14 09:54:20 PST
Attachment 78949 [details] did not build on win:
Build output: http://queues.webkit.org/results/7558043
Comment 6 WebKit Review Bot 2011-01-14 10:00:55 PST
Attachment 78949 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/7520056
Comment 7 Early Warning System Bot 2011-01-14 10:08:29 PST
Attachment 78951 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7506034
Comment 8 Build Bot 2011-01-14 10:11:49 PST
Attachment 78951 [details] did not build on win:
Build output: http://queues.webkit.org/results/7588041
Comment 9 WebKit Review Bot 2011-01-14 10:26:10 PST
Attachment 78949 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7606037
Comment 10 Tony Gentilcore 2011-01-14 10:32:02 PST
Created attachment 78957 [details]
Patch
Comment 11 WebKit Review Bot 2011-01-14 10:37:42 PST
Attachment 78951 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/7514038
Comment 12 Early Warning System Bot 2011-01-14 10:51:02 PST
Attachment 78957 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7626004
Comment 13 David Levin 2011-01-14 10:52:35 PST
Comment on attachment 78957 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78957&action=review

r+ (as long as it compiles).

One small nit.

> Source/WebCore/rendering/style/RenderStyle.h:91
> +struct ContentData;

Nit: I would put the struct into a separate grouping (like what is done in Source/WebCore/html/HTMLFormElement.h for example).
Comment 14 Build Bot 2011-01-14 11:04:43 PST
Attachment 78957 [details] did not build on win:
Build output: http://queues.webkit.org/results/7549041
Comment 15 Tony Gentilcore 2011-01-14 11:08:09 PST
> r+ (as long as it compiles).
The EWS bots will probably continue to find port-specific transitive deps. I won't land until they are all happy.

> Nit: I would put the struct into a separate grouping (like what is done in Source/WebCore/html/HTMLFormElement.h for example).
Done.
Comment 16 Tony Gentilcore 2011-01-14 11:08:14 PST
Created attachment 78966 [details]
Patch
Comment 17 WebKit Review Bot 2011-01-14 11:08:18 PST
Attachment 78957 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/7567040
Comment 18 WebKit Review Bot 2011-01-14 11:20:56 PST
Attachment 78957 [details] did not build on mac:
Build output: http://queues.webkit.org/results/7580048
Comment 19 WebKit Review Bot 2011-01-14 11:37:18 PST
Attachment 78957 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7513047
Comment 20 WebKit Review Bot 2011-01-14 11:44:43 PST
Attachment 78966 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/7564048
Comment 21 Build Bot 2011-01-14 11:47:16 PST
Attachment 78966 [details] did not build on win:
Build output: http://queues.webkit.org/results/7513048
Comment 22 Tony Gentilcore 2011-01-14 11:58:26 PST
Created attachment 78975 [details]
Patch
Comment 23 Early Warning System Bot 2011-01-14 11:59:40 PST
Attachment 78966 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7572048
Comment 24 WebKit Review Bot 2011-01-14 13:00:54 PST
Attachment 78966 [details] did not build on mac:
Build output: http://queues.webkit.org/results/7612051
Comment 25 Tony Gentilcore 2011-01-14 13:06:19 PST
Created attachment 78985 [details]
Patch
Comment 26 David Levin 2011-01-14 13:24:42 PST
Comment on attachment 78985 [details]
Patch

Same as before :)
Comment 27 WebKit Review Bot 2011-01-14 14:55:32 PST
Attachment 78985 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7625031
Comment 28 Tony Gentilcore 2011-01-14 16:27:19 PST
Committed r75837: <http://trac.webkit.org/changeset/75837>
Comment 29 WebKit Review Bot 2011-01-14 16:38:30 PST
http://trac.webkit.org/changeset/75837 might have broken Qt Linux Release minimal