Web Inspector: include source position in debugger call frames. This is needed for debugging beautified scripts.
Created attachment 78931 [details] Patch.
Attachment 78931 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/bindings/js/ScriptDebugServer.h:121: The parameter name "debuggerCallFrame" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/bindings/js/ScriptDebugServer.h:122: The parameter name "debuggerCallFrame" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 78935 [details] Fix style.
Comment on attachment 78935 [details] Fix style. View in context: https://bugs.webkit.org/attachment.cgi?id=78935&action=review > Source/WebCore/bindings/js/ScriptDebugServer.h:157 > + ScriptsMap m_scripts; This map is never populated nor cleared, is it intentional? r- for this
Created attachment 79148 [details] Use line:column instead of source position.
Attachment 79148 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/bindings/js/JavaScriptCallFrame.h:78: The parameter name "textPosition" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 79170 [details] Fix style.
Committed r76013: <http://trac.webkit.org/changeset/76013>