Bug 52442 – Web Inspector: do not use this as protocol message dispatcher in models / agents.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Models should never for InspectorBackend.registerDomainDispatcher("foo", this). There should be a clear way to tell whether method is being called from within front-end or by the backend.

[Pavel Feldman]

Created attachment 78930 [details]
[PATCH] Proposed change.

[Ilya Tikhonovsky]

Comment on attachment 78930 [details]
[PATCH] Proposed change.

View in context: https://bugs.webkit.org/attachment.cgi?id=78930&action=review

> Source/WebCore/inspector/front-end/DOMAgent.js:396
> -        this._idToDOMNode = {};
> +        this._domAgent._idToDOMNode = {};
>          if (payload && "id" in payload) {
> -            this.document = new WebInspector.DOMDocument(this, this._window, payload);
> -            this._idToDOMNode[payload.id] = this.document;
> -            this._bindNodes(this.document.children);
> +            this._domAgent.document = new WebInspector.DOMDocument(this, this._domAgent._window, payload);
> +            this._domAgent._idToDOMNode[payload.id] = this._domAgent.document;
> +            this._domAgent._bindNodes(this._domAgent.document.children);
>              WebInspector.breakpointManager.restoreDOMBreakpoints();
>          } else
> -            this.document = null;
> -        WebInspector.panels.elements.setDocument(this.document);
> +            this._domAgent.document = null;
> +        WebInspector.panels.elements.setDocument(this._domAgent.document);

please make it a pure delegate.

> Source/WebCore/inspector/front-end/ProfilesPanel.js:633
> +WebInspector.ProfilerDispatcher.prototype = {
> +    profilerWasEnabled: function()
> +    {
> +        if (this._profiler._profilerEnabled)
> +            return;
> +
> +        this._profiler._profilerEnabled = true;
> +
> +        this._profiler._reset();
> +        if (this._profiler.visible)
> +            this._profiler._populateProfiles();
> +    },

ditto

> Source/WebCore/inspector/front-end/ProfilesPanel.js:642
> +    profilerWasDisabled: function()
> +    {
> +        if (!this._profiler._profilerEnabled)
> +            return;
> +
> +        this._profiler._profilerEnabled = false;
> +        this._profiler._reset();
> +    },

ditto

[Pavel Feldman]

Created attachment 78938 [details]
[PATCH] Review comments addressed.

[Pavel Feldman]

Comment on attachment 78938 [details]
[PATCH] Review comments addressed.

Clearing flags on attachment: 78938

Committed r75791: <http://trac.webkit.org/changeset/75791>

[Pavel Feldman]

All reviewed patches have been landed.  Closing bug.