Bug 52429 - Web Inspector: extract InspectorSettings from InspectorState, simplify it.
Summary: Web Inspector: extract InspectorSettings from InspectorState, simplify it.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-14 00:37 PST by Pavel Feldman
Modified: 2011-01-14 01:57 PST (History)
13 users (show)

See Also:

Attachments
[PATCH] Proposed change (34.37 KB, patch)
2011-01-14 00:43 PST, Pavel Feldman 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-01-14 00:37:13 PST 
Patch to follow.
Comment 1 Pavel Feldman 2011-01-14 00:43:42 PST 
Created attachment 78900 [details]
[PATCH] Proposed change
Comment 2 Yury Semikhatsky 2011-01-14 00:52:40 PST 
Comment on attachment 78900 [details]
[PATCH] Proposed change

View in context: https://bugs.webkit.org/attachment.cgi?id=78900&action=review

> Source/WebCore/inspector/InspectorController.cpp:194
>  {

These 4 methods should live in the WebKit layer.

> Source/WebCore/inspector/InspectorController.cpp:852
> +    m_state->setBoolean(InspectorState::monitoringXHR, m_settings->getBoolean(InspectorSettings::MonitoringXHREnabled));

How will corresponding setting be changed when this property is modified on the state?
Comment 3 Pavel Feldman 2011-01-14 01:05:42 PST 
(In reply to comment #2)
> (From update of attachment 78900 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=78900&action=review
> 
> > Source/WebCore/inspector/InspectorController.cpp:194
> >  {
> 
> These 4 methods should live in the WebKit layer.
> 

Yes, I remember you wanted to do that properly.

> > Source/WebCore/inspector/InspectorController.cpp:852
> > +    m_state->setBoolean(InspectorState::monitoringXHR, m_settings->getBoolean(InspectorSettings::MonitoringXHREnabled));
> 
> How will corresponding setting be changed when this property is modified on the state?

See line 468.
Comment 4 Pavel Feldman 2011-01-14 01:48:29 PST 
Landed as r75777.
Comment 5 WebKit Review Bot 2011-01-14 01:57:54 PST 
http://trac.webkit.org/changeset/75777 might have broken GTK Linux 64-bit Debug