RESOLVED FIXED 52429
Web Inspector: extract InspectorSettings from InspectorState, simplify it. 
https://bugs.webkit.org/show_bug.cgi?id=52429
Summary Web Inspector: extract InspectorSettings from InspectorState, simplify it.
Pavel Feldman
Reported 2011-01-14 00:37:13 PST
Patch to follow.
Attachments
[PATCH] Proposed change (34.37 KB, patch)
2011-01-14 00:43 PST, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-01-14 00:43:42 PST
Created attachment 78900 [details] [PATCH] Proposed change
Yury Semikhatsky
Comment 2 2011-01-14 00:52:40 PST
Comment on attachment 78900 [details] [PATCH] Proposed change View in context: https://bugs.webkit.org/attachment.cgi?id=78900&action=review > Source/WebCore/inspector/InspectorController.cpp:194 > { These 4 methods should live in the WebKit layer. > Source/WebCore/inspector/InspectorController.cpp:852 > + m_state->setBoolean(InspectorState::monitoringXHR, m_settings->getBoolean(InspectorSettings::MonitoringXHREnabled)); How will corresponding setting be changed when this property is modified on the state?
Pavel Feldman
Comment 3 2011-01-14 01:05:42 PST
(In reply to comment #2) > (From update of attachment 78900 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=78900&action=review > > > Source/WebCore/inspector/InspectorController.cpp:194 > > { > > These 4 methods should live in the WebKit layer. > Yes, I remember you wanted to do that properly. > > Source/WebCore/inspector/InspectorController.cpp:852 > > + m_state->setBoolean(InspectorState::monitoringXHR, m_settings->getBoolean(InspectorSettings::MonitoringXHREnabled)); > > How will corresponding setting be changed when this property is modified on the state? See line 468.
Pavel Feldman
Comment 4 2011-01-14 01:48:29 PST
Landed as r75777.
WebKit Review Bot
Comment 5 2011-01-14 01:57:54 PST
http://trac.webkit.org/changeset/75777 might have broken GTK Linux 64-bit Debug
Note You need to log in before you can comment on or make changes to this bug.