Bug 52424 - check-webkit-style: _FunctionState should use Position to know where items are.
Summary: check-webkit-style: _FunctionState should use Position to know where items are.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks: 52271
  Show dependency tree / graph
 
Reported: 2011-01-13 22:09 PST by David Levin
Modified: 2011-01-14 01:57 PST (History)
5 users (show)

See Also:

Attachments
Patch (16.07 KB, patch)
2011-01-13 22:24 PST, David Levin 		no flags Details | Formatted Diff | Diff
Patch (16.04 KB, patch)
2011-01-13 22:30 PST, David Levin 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2011-01-13 22:09:25 PST 
This retains more information which makes it easier to do things like pure virtual detection because one can search for '= 0' between the end of the parameters and the end of the function (using the positions).
Comment 1 David Levin 2011-01-13 22:24:41 PST 
Created attachment 78890 [details]
Patch
Comment 2 WebKit Review Bot 2011-01-13 22:27:20 PST 
Attachment 78890 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1

Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:386:  whitespace before ':'  [pep8/E203] [5]
Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:396:  whitespace before ':'  [pep8/E203] [5]
Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:405:  whitespace before ':'  [pep8/E203] [5]
Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:414:  whitespace before ':'  [pep8/E203] [5]
Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:423:  whitespace before ':'  [pep8/E203] [5]
Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:432:  whitespace before ':'  [pep8/E203] [5]
Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:450:  whitespace before ':'  [pep8/E203] [5]
Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:464:  whitespace before ':'  [pep8/E203] [5]
Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:475:  whitespace before ':'  [pep8/E203] [5]
Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:487:  whitespace before ':'  [pep8/E203] [5]
Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:502:  whitespace before ':'  [pep8/E203] [5]
Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:521:  whitespace before ':'  [pep8/E203] [5]
Total errors found: 12 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 David Levin 2011-01-13 22:30:15 PST 
Created attachment 78891 [details]
Patch
Comment 4 David Levin 2011-01-13 22:31:47 PST 
(In reply to comment #2)
> Attachment 78890 [details] did not pass style-queue:

Bummer. I hate it when I fix the issues and then don't commit the change (and only upload through head).
Comment 5 Shinichiro Hamaji 2011-01-13 22:31:54 PST 
Comment on attachment 78891 [details]
Patch

Looks good.
Comment 6 WebKit Commit Bot 2011-01-13 22:58:34 PST 
Comment on attachment 78891 [details]
Patch

Clearing flags on attachment: 78891

Committed r75772: <http://trac.webkit.org/changeset/75772>
Comment 7 WebKit Commit Bot 2011-01-13 22:58:40 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 WebKit Review Bot 2011-01-14 01:57:47 PST 
http://trac.webkit.org/changeset/75772 might have broken GTK Linux 32-bit Debug