RESOLVED FIXED Bug 52424
check-webkit-style: _FunctionState should use Position to know where items are. 
https://bugs.webkit.org/show_bug.cgi?id=52424
Summary check-webkit-style: _FunctionState should use Position to know where items are.
David Levin
Reported 2011-01-13 22:09:25 PST
This retains more information which makes it easier to do things like pure virtual detection because one can search for '= 0' between the end of the parameters and the end of the function (using the positions).
Attachments
Patch (16.07 KB, patch)
2011-01-13 22:24 PST, David Levin 		no flags
DetailsFormatted DiffDiff
Patch (16.04 KB, patch)
2011-01-13 22:30 PST, David Levin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2011-01-13 22:24:41 PST
Created attachment 78890 [details] Patch
WebKit Review Bot
Comment 2 2011-01-13 22:27:20 PST
Attachment 78890 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:386: whitespace before ':' [pep8/E203] [5] Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:396: whitespace before ':' [pep8/E203] [5] Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:405: whitespace before ':' [pep8/E203] [5] Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:414: whitespace before ':' [pep8/E203] [5] Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:423: whitespace before ':' [pep8/E203] [5] Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:432: whitespace before ':' [pep8/E203] [5] Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:450: whitespace before ':' [pep8/E203] [5] Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:464: whitespace before ':' [pep8/E203] [5] Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:475: whitespace before ':' [pep8/E203] [5] Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:487: whitespace before ':' [pep8/E203] [5] Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:502: whitespace before ':' [pep8/E203] [5] Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:521: whitespace before ':' [pep8/E203] [5] Total errors found: 12 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
David Levin
Comment 3 2011-01-13 22:30:15 PST
Created attachment 78891 [details] Patch
David Levin
Comment 4 2011-01-13 22:31:47 PST
(In reply to comment #2) > Attachment 78890 [details] did not pass style-queue: Bummer. I hate it when I fix the issues and then don't commit the change (and only upload through head).
Shinichiro Hamaji
Comment 5 2011-01-13 22:31:54 PST
Comment on attachment 78891 [details] Patch Looks good.
WebKit Commit Bot
Comment 6 2011-01-13 22:58:34 PST
Comment on attachment 78891 [details] Patch Clearing flags on attachment: 78891 Committed r75772: <http://trac.webkit.org/changeset/75772>
WebKit Commit Bot
Comment 7 2011-01-13 22:58:40 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 8 2011-01-14 01:57:47 PST
http://trac.webkit.org/changeset/75772 might have broken GTK Linux 32-bit Debug
Note You need to log in before you can comment on or make changes to this bug.