Bug 52419 – REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL

<rdar://problem/8827065>

Created attachment 78882 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 78882 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78882&action=review

Looks great.

> Tools/ChangeLog:8
> +        Allow to furthur control the behavior of the willSendRequest delegate callback by making it

furthur?

> LayoutTests/http/tests/loading/cross-origin-XHR-willLoadRequest-expected.txt:5
> +CONSOLE MESSAGE: line 1: XMLHttpRequest cannot load http://localhost:8000/loading/resources/foo.txt. Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin.

Please make this test explain what the expected behavior is. Does it somehow pass on other platforms, or does it need to be added to Skipped lists?

(In reply to comment #3)
> (From update of attachment 78882 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=78882&action=review
> 
> Looks great.
> 
> > Tools/ChangeLog:8
> > +        Allow to furthur control the behavior of the willSendRequest delegate callback by making it
> 
> furthur?

Something wrong with my spulling?

> 
> > LayoutTests/http/tests/loading/cross-origin-XHR-willLoadRequest-expected.txt:5
> > +CONSOLE MESSAGE: line 1: XMLHttpRequest cannot load http://localhost:8000/loading/resources/foo.txt. Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin.
> 
> Please make this test explain what the expected behavior is.

OK. 

> Does it somehow pass on other platforms, or does it need to be added to Skipped lists?

I don't see how It can pass on other platforms. I suppose the EWS does not run new tests. I will skip.

Thanks for the review!

Fixed in <http://trac.webkit.org/changeset/75768>.

[WebKit Review Bot]

http://trac.webkit.org/changeset/75768 might have broken Qt Linux Release

[Hayato Ito]

I've fixed Skipped lists in r75768:
https://trac.webkit.org/changeset/75771

It seems they don't have '.html' suffix.