Bug 52416 - webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
Summary: webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-13 17:43 PST by Eric Seidel (no email)
Modified: 2011-01-14 01:21 PST (History)
6 users (show)

See Also:

Attachments
Patch (4.74 KB, patch)
2011-01-13 17:45 PST, Eric Seidel (no email) 		mihaip: review+
mihaip: commit-queue+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-01-13 17:43:43 PST 
webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
Comment 1 Eric Seidel (no email) 2011-01-13 17:45:21 PST 
Created attachment 78879 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-01-13 17:57:03 PST 
Committed r75761: <http://trac.webkit.org/changeset/75761>
Comment 3 Philippe Normand 2011-01-14 00:38:31 PST 
This broke GTK+ 32-bits Debug:

Traceback (most recent call last):
  File "./Tools/Scripts/test-webkitpy", line 266, in <module>
    Tester().run_tests(sys.argv, external_package_paths)
  File "/home/slave/webkitgtk/gtk-linux-32-debug/build/Tools/Scripts/webkitpy/test/main.py", line 140, in run_tests
    unittest.main(argv=sys_argv, module=None)
  File "/usr/lib/python2.5/unittest.py", line 767, in __init__
    self.parseArgs(argv)
  File "/usr/lib/python2.5/unittest.py", line 794, in parseArgs
    self.createTests()
  File "/usr/lib/python2.5/unittest.py", line 800, in createTests
    self.module)
  File "/usr/lib/python2.5/unittest.py", line 565, in loadTestsFromNames
    suites = [self.loadTestsFromName(name, module) for name in names]
  File "/usr/lib/python2.5/unittest.py", line 533, in loadTestsFromName
    module = __import__('.'.join(parts_copy))
  File "/home/slave/webkitgtk/gtk-linux-32-debug/build/Tools/Scripts/webkitpy/common/checkout/api_unittest.py", line 135
    invalid_utf8 = str(b"\255")
                             ^
SyntaxError: invalid syntax
Comment 4 Eric Seidel (no email) 2011-01-14 01:21:28 PST 
I found that syntax on the interblags.  I assume b"\123" is a bytearray, I suspect the literal form is a new thing in 2.6.