Bug 52416 – webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eric Seidel (no email)]

webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files

[Eric Seidel (no email)]

Created attachment 78879 [details]
Patch

[Eric Seidel (no email)]

Committed r75761: <http://trac.webkit.org/changeset/75761>

[Philippe Normand]

This broke GTK+ 32-bits Debug:

Traceback (most recent call last):
  File "./Tools/Scripts/test-webkitpy", line 266, in <module>
    Tester().run_tests(sys.argv, external_package_paths)
  File "/home/slave/webkitgtk/gtk-linux-32-debug/build/Tools/Scripts/webkitpy/test/main.py", line 140, in run_tests
    unittest.main(argv=sys_argv, module=None)
  File "/usr/lib/python2.5/unittest.py", line 767, in __init__
    self.parseArgs(argv)
  File "/usr/lib/python2.5/unittest.py", line 794, in parseArgs
    self.createTests()
  File "/usr/lib/python2.5/unittest.py", line 800, in createTests
    self.module)
  File "/usr/lib/python2.5/unittest.py", line 565, in loadTestsFromNames
    suites = [self.loadTestsFromName(name, module) for name in names]
  File "/usr/lib/python2.5/unittest.py", line 533, in loadTestsFromName
    module = __import__('.'.join(parts_copy))
  File "/home/slave/webkitgtk/gtk-linux-32-debug/build/Tools/Scripts/webkitpy/common/checkout/api_unittest.py", line 135
    invalid_utf8 = str(b"\255")
                             ^
SyntaxError: invalid syntax

[Eric Seidel (no email)]

I found that syntax on the interblags.  I assume b"\123" is a bytearray, I suspect the literal form is a new thing in 2.6.