Bug 52408 - [Qt] QtTestBrowser should have a UI setting to disable plugins
Summary: [Qt] QtTestBrowser should have a UI setting to disable plugins
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-13 16:31 PST by Yael
Modified: 2011-01-26 09:33 PST (History)
3 users (show)

See Also:

Attachments
Add "Disable Plugins" under Settings Menu (2.48 KB, patch)
2011-01-25 14:19 PST, mansi mithal 		tonikitoo: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Add "Disable Plugins" under Settings Menu (2.50 KB, patch)
2011-01-26 08:32 PST, mansi mithal 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yael 2011-01-13 16:31:26 PST 
It wuld help a lot when debugging if we could turn off plugins at runtime.
Comment 1 mansi mithal 2011-01-20 12:36:21 PST 
I have the patch ready. But since the patch depends on the bug : 52817 , I will submit it after the other one gets checked in.
Comment 2 mansi mithal 2011-01-25 14:19:00 PST 
Created attachment 80119 [details]
Add "Disable Plugins" under Settings Menu
Comment 3 Antonio Gomes 2011-01-25 19:35:18 PST 
Comment on attachment 80119 [details]
Add "Disable Plugins" under Settings Menu

View in context: https://bugs.webkit.org/attachment.cgi?id=80119&action=review

> Tools/ChangeLog:5
> +        QtTestBrowser should have a UI  Setting to disable plugins

two spaces after "UI"

> Tools/ChangeLog:9
> +        under the "Settings" menu 

You missed a "." at the end of sentence.
Comment 4 WebKit Commit Bot 2011-01-25 19:38:42 PST 
Comment on attachment 80119 [details]
Add "Disable Plugins" under Settings Menu

Rejecting attachment 80119 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-sf-cq', 'ap..." exit_code: 2

Last 500 characters of output:
/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/QtTestBrowser/launcherwindow.cpp
Hunk #1 succeeded at 371 with fuzz 2 (offset 4 lines).
Hunk #2 succeeded at 783 with fuzz 1 (offset 9 lines).
patching file Tools/QtTestBrowser/launcherwindow.h
Hunk #1 FAILED at 163.
1 out of 1 hunk FAILED -- saving rejects to file Tools/QtTestBrowser/launcherwindow.h.rej

Failed to run "[u'/Projects/CommitQueue/Tools/Scripts/svn-apply', u'--reviewer', u'Antonio Gomes', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/7559364
Comment 5 mansi mithal 2011-01-26 08:32:22 PST 
Created attachment 80196 [details]
Add "Disable Plugins" under Settings Menu
Comment 6 WebKit Commit Bot 2011-01-26 09:32:21 PST 
The commit-queue encountered the following flaky tests while processing attachment 80196 [details]:

http/tests/xmlhttprequest/cross-origin-authorization.html bug 52398 (author: ap@webkit.org)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2011-01-26 09:33:00 PST 
Comment on attachment 80196 [details]
Add "Disable Plugins" under Settings Menu

Clearing flags on attachment: 80196

Committed r76693: <http://trac.webkit.org/changeset/76693>
Comment 8 WebKit Commit Bot 2011-01-26 09:33:03 PST 
All reviewed patches have been landed.  Closing bug.