WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
52383
RTL: logical order of leaf boxes is not computed correctly for iso-8859-8 when dir=RTL
https://bugs.webkit.org/show_bug.cgi?id=52383
Summary
RTL: logical order of leaf boxes is not computed correctly for iso-8859-8 whe...
Xiaomei Ji
Reported
2011-01-13 11:14:06 PST
After the fix of issue 52128, logical order of leaf boxes (getLeafBoxesInLogicalOrder in visible_units.cpp or RootInlineBox::determineLogicalOrderOfLeafBoxes() after fix of 78828) is not computed correctly for iso-8859-8. if (m_leafBoxesInLogicalOrder || renderer()->style()->visuallyOrdered()) return; should be changed to: if (m_leafBoxesInLogicalOrder) return; if (renderer()->style()->visuallyOrdered()) && direction() == RTL) // simply reverse the boxes.
Attachments
Add attachment
proposed patch, testcase, etc.
Ahmad Saleem
Comment 1
2022-08-16 16:08:49 PDT
Following commit - refactored "getLeafBoxesInLogicalOrder" into InlineFlowBox:
https://github.com/WebKit/WebKit/commit/51566ba5fc8e70f56d28080f0c3523e6d94195db
I can only find reference to "leafBoxesInLogicalOrder" in following places:
https://github.com/WebKit/WebKit/blob/06829a72816b3507674af7be8a740a4964ae3518/Source/WebCore/layout/integration/inline/InlineIteratorLogicalOrderTraversal.h#L64
https://github.com/WebKit/WebKit/blob/06829a72816b3507674af7be8a740a4964ae3518/Source/WebCore/layout/integration/inline/InlineIteratorLogicalOrderTraversal.cpp#L97
https://github.com/WebKit/WebKit/blob/ce0ee18aa01d4d38b4dc7e9535ea61e24234c6cb/Source/WebCore/rendering/svg/SVGRootInlineBox.cpp#L343
____ I think the code is changed significantly and this might not be applicable anymore but appreciate if someone can confirm. I am going to tag this to "zalan" as well. Thanks!
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug