Bug 52367 – [Chromium]: FindInPage scoping function needs to handle user-select-none better

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Finnur Thorarinsson]

The scoping function used in Chromium does not handle user-select-none well. It basically stops when it hits the first user-select-none style. This is similar to the problem fixed in bug 33508 and the same fix applies here as well.

I'll upload a patch.

[Finnur Thorarinsson]

Created attachment 78805 [details]
A patch for this

[Finnur Thorarinsson]

Also related: bug 51623.

[WebKit Review Bot]

Attachment 78805 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'WebKit/chromium/ChangeLog', u'WebKit/chrom..." exit_code: 1

WebKit/chromium/ChangeLog:3:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
Total errors found: 5 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Finnur Thorarinsson]

Created attachment 78806 [details]
Another patch, addressing crlf issue.

[WebKit Commit Bot]

Comment on attachment 78806 [details]
Another patch, addressing crlf issue.

Rejecting attachment 78806 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-..." exit_code: 1

Last 500 characters of output:
rks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 361, in _call_chain
    result = func(*args)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_http.py", line 756, in https_open
    return self.do_open(conn_factory, req)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_http.py", line 706, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [Errno 60] Operation timed out>

Full output: http://queues.webkit.org/results/7521018

[WebKit Commit Bot]

Comment on attachment 78806 [details]
Another patch, addressing crlf issue.

Rejecting attachment 78806 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'land-a..." exit_code: 1

Last 500 characters of output:
WebCore/rendering/RenderSlider.cpp
	M	Source/WebCore/rendering/MediaControlElements.cpp
	M	Source/WebCore/rendering/RenderSlider.h
	M	Source/WebCore/css/CSSStyleSelector.cpp
r75725 = 61dc5b176da5cc962fff04efe17be06ac33c2c32 (refs/remotes/trunk)
	M	Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
	M	Tools/ChangeLog
r75726 = a331c0a2664e0c98329756cfa83269df92c74daa (refs/remotes/trunk)
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/trunk.

Full output: http://queues.webkit.org/results/7555019

[Ojan Vafai]

Finnur, I missed this in the review. You're ChangeLog needs the dummy line for filling in the reviewer at that top. For example, see the one at https://bugs.webkit.org/attachment.cgi?id=78826&action=review.

[Finnur Thorarinsson]

Created attachment 78911 [details]
Same patch, with dummy reviewer line in ChangeLog (and svn up'ed)

[Finnur Thorarinsson]

Fixed. Sorry about that. Forgot it was necessary.

[David Levin]

Comment on attachment 78911 [details]
Same patch, with dummy reviewer line in ChangeLog (and svn up'ed)

Per comments in irc.

[Finnur Thorarinsson]

Created attachment 78912 [details]
Previously reviewed, just missing reviewer line.

[WebKit Review Bot]

Comment on attachment 78912 [details]
Previously reviewed, just missing reviewer line.

Rejecting attachment 78912 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Commit Bot]

Comment on attachment 78912 [details]
Previously reviewed, just missing reviewer line.

Clearing flags on attachment: 78912

Committed r75784: <http://trac.webkit.org/changeset/75784>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.